Compiling literalparser.cpp for WINSCW complains about "undefined identifier mode". "mode" has been defined in the template specialisation, but the prototype of the function has a diffrent variable name for it "parserMode". This is addenum for https://bugs.webkit.org/show_bug.cgi?id=28069. Even after the inlining Literalparser.cpp fails to compile with mwccsym Version 3.2.5 build 482 (Build 482). There is two ways of fixing the compiler issue. Either remove the parserMode from prototype or make the prototype to have the same name for argument as the implementation. I chose the latter as it makes it more clear that we are dealing here with template specialisation.
Created attachment 39438 [details] literalparser.h patch
I continue to be entertained by this compiler. :) I think "parserMode" is clearer than "mode" and would have changed them both to "parserMode", but this is also OK.
Comment on attachment 39438 [details] literalparser.h patch Please don't mark the patch as r+ but use r? instead to ask for a review :)
Comment on attachment 39438 [details] literalparser.h patch There we go, r=me. This is a really simple fix :)
Landed in r48462