Bug 28069 – Add inline to help winscw compiler resolve specialized argument in templated functions.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Qt

[Yongjun Zhang]

Wiscw compiler cannot resolve template argument "mode" from the following code:

----------------------------------------------------
template <int mode> void test_function()
{
    int m = mode; // it complains mode is not defined
}
----------------------------------------------------

If we inline this function, the compiler won't report the error.

[Yongjun Zhang]

Created attachment 34281 [details]
Add inline to help winscw compiler resolve specialized argument in templated functions.

The inline is only enabled for winscw compiler; for other compilers, it will be disabled to avoid increasing the binary size.

[Eric Seidel (no email)]

Comment on attachment 34281 [details]
Add inline to help winscw compiler resolve specialized argument in templated functions.

I don't see why this can't be inline for all compilers.  "inline" is a hint anyway.  Compilers can (and will) ignore it.

[Eric Seidel (no email)]

you could add a comment about how "inline" is required there to help the winscw compiler if you like.

[Yongjun Zhang]

Created attachment 34292 [details]
Modified patch as per Eric's comments.

Thanks for the quick review.

The new patch removes winscw compiler specific flag.

[Eric Seidel (no email)]

Comment on attachment 34292 [details]
Modified patch as per Eric's comments.

LGTM.

[Adam Barth]

Comment on attachment 34292 [details]
Modified patch as per Eric's comments.

Clearing review flag on attachment: 34292

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	JavaScriptCore/ChangeLog
	M	JavaScriptCore/runtime/LiteralParser.cpp
Committed r46910
	M	LayoutTests/platform/mac/Skipped
	M	LayoutTests/platform/win/Skipped
	M	LayoutTests/ChangeLog
r46909 = b66fe77cc3bbc2d501a8b5d5a3fc7dd3d62d7df0 (trunk)
	M	JavaScriptCore/runtime/LiteralParser.cpp
	M	JavaScriptCore/ChangeLog
r46910 = 0fc235ef070baf8ffb224dc034ba71c824933021 (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/46910

[Adam Barth]

All reviewed patches have been landed.  Closing bug.