Bug 29111 - [V8] Cleanup includes and forward declarations in V8Proxy.h
Summary: [V8] Cleanup includes and forward declarations in V8Proxy.h
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nate Chapin
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-09-09 16:45 PDT by Nate Chapin
Modified: 2009-09-09 23:05 PDT (History)
2 users (show)

See Also:


Attachments
patch (2.57 KB, patch)
2009-09-09 16:50 PDT, Nate Chapin
no flags Details | Formatted Diff | Diff
test (76.73 KB, text/plain)
2009-09-09 22:54 PDT, Cho Kyung Bin
no flags Details

Note You need to log in before you can comment on or make changes to this bug.
Description Nate Chapin 2009-09-09 16:45:51 PDT
https://bugs.webkit.org/show_bug.cgi?id=29051 demonstrated that V8Proxy.h could use some cleanup work.  I did the bare minimum to get this file suitable for upstreaming, and it appears I should have double-checked the includes and forward declarations to see what was no longer necessary.
Comment 1 Nate Chapin 2009-09-09 16:50:51 PDT
Created attachment 39311 [details]
patch
Comment 2 Adam Barth 2009-09-09 17:02:26 PDT
Comment on attachment 39311 [details]
patch

Awesome patch!
Comment 3 WebKit Commit Bot 2009-09-09 17:39:25 PDT
Comment on attachment 39311 [details]
patch

Clearing flags on attachment: 39311

Committed r48238: <http://trac.webkit.org/changeset/48238>
Comment 4 WebKit Commit Bot 2009-09-09 17:39:28 PDT
All reviewed patches have been landed.  Closing bug.
Comment 5 Cho Kyung Bin 2009-09-09 22:54:16 PDT
Created attachment 39323 [details]
test

test
Comment 6 David Levin 2009-09-09 23:05:27 PDT
Comment on attachment 39323 [details]
test

According to biny77 this was done by mistake.