WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
29051
[V8] Chromium mac build break due to spurious <iterator> include in V8Proxy
https://bugs.webkit.org/show_bug.cgi?id=29051
Summary
[V8] Chromium mac build break due to spurious <iterator> include in V8Proxy
Nate Chapin
Reported
2009-09-08 14:05:51 PDT
V8Proxy.h unnecessarily includes <iterator>, which just recently started being included in an ObjC include chain. This library appears to make use of some exception code, and the proper redefines are not present to make try/catch blocks play nice in a compile that doesn't allow exceptions. Fixing should be as simple as removing the <iterator> include.
Attachments
patch
(981 bytes, patch)
2009-09-08 14:08 PDT
,
Nate Chapin
dglazkov
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Nate Chapin
Comment 1
2009-09-08 14:08:36 PDT
Created
attachment 39210
[details]
patch
Dimitri Glazkov (Google)
Comment 2
2009-09-08 14:09:59 PDT
Comment on
attachment 39210
[details]
patch Victory! r=me.
Nate Chapin
Comment 3
2009-09-08 14:14:09 PDT
Landed as
r48185
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug