This is the first step of https://bugs.webkit.org/show_bug.cgi?id=27897 which is a pretty major cleanup of all the dom storage layout tests. I'm just changing this one to begin with to get buy-in on the approach. This also adds a new method to the fast/js/js-test-pre.js that runs a command and prints it to the screen. This should really help with making the output of the tests readable without looking at the source code.
Created attachment 38975 [details] Patch v1
I've cc'ed everyone that I (think I) remember commenting about the dom storage layout tests at some point or another. Please do take a quick look and let me know if you'd be happy r+ing patches of this style in the future. Once we can all agree on it, I'll go ahead and convert the rest in subsequent patches/bugs. Thanks!
Comment on attachment 38975 [details] Patch v1 Maybe evalAndLog instead? Either way, this looks fine.
evalAndLog seems better. I think I might prefix error messages with something as well. Maybe "Ran: " or "Executed: " or something? I'll hold off committing until tomorrow evening in case there's more feedback. (So please don't put this in the commit queue!!!!!)
Comment on attachment 38975 [details] Patch v1 Not ending up in the commit-queue is an easily solved problem. :)
All right. Hopefully silence means agreement. :-) I'll submit this (with the function name change) and start converting others tomorrow. I'll probably do them in small chunks (1-3 tests per patch) to keep things easily reviewable.
One thing you might try is to commit this while folks are on the IRC channel. That can be a good way to flush out opinions from folks who might not comment on the bug beforehand.
Committed r48143: <http://trac.webkit.org/changeset/48143>