Bug 28723 - Stop skipping LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html and add Windows expectations
Summary: Stop skipping LayoutTests/http/tests/xmlhttprequest/xmlhttprequest-missing-fi...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Julie Parent
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-08-25 15:49 PDT by Julie Parent
Modified: 2009-08-26 13:34 PDT (History)
1 user (show)

See Also:


Attachments
Adds windows results, removes test from SKIPPED (2.45 KB, patch)
2009-08-26 11:50 PDT, Julie Parent
ap: review-
Details | Formatted Diff | Diff
Updated patch, changes platform/mac expectations instead of win, fixes tabs in ChangeLog. (3.14 KB, patch)
2009-08-26 13:05 PDT, Julie Parent
ap: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Julie Parent 2009-08-25 15:49:52 PDT
http/tests/xmlhttprequest/xmlhttprequest-missing-file-exception.html results on Windows differ from Mac in that statusText is "Not Found" rather than "OK".  This is due to https://bugs.webkit.org/show_bug.cgi?id=24572 where Mac always returns "OK", no matter what.  Firefox, IE, Chrome all return "Not Found" so this Windows behavior is correct and should just have a different test expectation, not be skipped.
Comment 1 Julie Parent 2009-08-26 11:50:20 PDT
Created attachment 38628 [details]
Adds windows results, removes test from SKIPPED
Comment 2 Alexey Proskuryakov 2009-08-26 11:53:53 PDT
Comment on attachment 38628 [details]
Adds windows results, removes test from SKIPPED

It's Mac results that are incorrect, so platform/mac should have custom
results, not Windows.
Comment 3 Alexey Proskuryakov 2009-08-26 11:54:39 PDT
Oh, and there are tabs in ChangeLog.
Comment 4 Julie Parent 2009-08-26 13:05:36 PDT
Created attachment 38634 [details]
Updated patch, changes platform/mac expectations instead of win, fixes tabs in ChangeLog.
Comment 5 Alexey Proskuryakov 2009-08-26 13:16:17 PDT
Comment on attachment 38634 [details]
Updated patch, changes platform/mac expectations instead of win, fixes tabs in ChangeLog.

r=me, thanks!
Comment 6 Julie Parent 2009-08-26 13:34:44 PDT
Committed in http://trac.webkit.org/changeset/47790