RESOLVED FIXED284508
Remove Quirk needsIPadMiniUserAgent for huya.com 
https://bugs.webkit.org/show_bug.cgi?id=284508
Summary Remove Quirk needsIPadMiniUserAgent for huya.com
Karl Dubost
Reported 2024-12-11 21:09:13 PST
Currently on regular iPad, huya.com is receiving iPad Mini User Agent instead of the traditional desktop user agent. Initially this Quirk was added through Bug 198484 on 2019-06-04 https://github.com/WebKit/WebKit/commit/4bb8f0f34179bd8ed4dcafeda205f65b5b8d6c87#diff-d2eb30e968da05615b61df7746f0d13b708da1629b083d455e1f98de80367bebR1293-R1295 then moved later on to https://github.com/WebKit/WebKit/blob/ba1fbaadee0af044adad5a31c2eca663007c44b2/Source/WebCore/page/Quirks.cpp#L1677 The reason for adding it is at the time this site is that receiving the desktop UA, some sites were sending the Flash Player to the users which was not supported on iOS devices. The Flah player end of life was programmed for 2020. This needs to be tested with Quirks disabled. If the site is working without the iPad Mini UA, then we can remove this quirk.
Attachments
Add attachment proposed patch, testcase, etc.
Wenson Hsieh
Comment 1 2024-12-11 21:12:33 PST
More context in rdar://48389965
Karl Dubost
Comment 2 2024-12-11 21:23:13 PST
With the iPad Mini UA override, https://huya.com/ redirects to https://m.huya.com/ It is slightly more difficult to test because a tap on a video will open a new tab which will have the iPad Mini UA override. https://www.huya.com/video/play/1029308934.html We receive a page where the video is working. The layout in portrait mode is a bit too big Basically the top and side menu are fitting the viewport BUT the content inside is sliding. Fwiw the layout issue is the same on desktop computer with a narrow window In landscape mode the layout fits just right, just like desktop. SO no real issues with the layout and differences with desktop. Videos: The videos are working without issues. Play and Pause volume, but the sound icon and the volume scruber is not working on sliding. While the position changes on tap, it doesn't change the sound volume. On Desktop the player is working as expected for all features. The scrubbing for the timeline is working. Full time is working. Issues to solve: * Touch interaction for the video player for the sound to be fixed.
Radar WebKit Bug Importer
Comment 3 2024-12-11 21:24:42 PST
<rdar://problem/141335024>
Karl Dubost
Comment 4 2025-05-08 17:13:16 PDT
Pull request: https://github.com/WebKit/WebKit/pull/45136
EWS
Comment 5 2025-05-09 09:30:01 PDT
Committed 294713@main (01256f4fbfa9): <https://commits.webkit.org/294713@main> Reviewed commits have been landed. Closing PR #45136 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.