Bug 198484 – Upstream content mode support into open source from WebKitAdditions

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit Misc.

[Wenson Hsieh]

SSIA

[Radar WebKit Bug Importer]

<rdar://problem/51355671>

[Wenson Hsieh]

Created attachment 371198 [details]
Patch

[Andy Estes]

Comment on attachment 371198 [details]
Patch

rs=me once EWS is green.

[Wenson Hsieh]

Created attachment 371203 [details]
Fix open source iOS build

[Wenson Hsieh]

Created attachment 371217 [details]
Try to fix API tests on open source iOS

[EWS Watchlist]

Comment on attachment 371217 [details]
Try to fix API tests on open source iOS

Attachment 371217 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12367021

New failing tests:
platform/ipad/fast/viewport/empty-meta.html
platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-not-ignore-meta-viewport.html
platform/ipad/media/modern-media-controls/media-documents/media-document-audio-ios-sizing.html
media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode.html

[EWS Watchlist]

Created attachment 371231 [details]
Archive of layout-test-results from ews125 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews125  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[Wenson Hsieh]

(In reply to Build Bot from comment #6)
> Comment on attachment 371217 [details]
> Try to fix API tests on open source iOS
> 
> Attachment 371217 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: https://webkit-queues.webkit.org/results/12367021
> 
> New failing tests:
> platform/ipad/fast/viewport/empty-meta.html
> platform/ipad/fast/viewport/viewport-unchanged-by-minimum-effective-width-if-
> not-ignore-meta-viewport.html
> platform/ipad/media/modern-media-controls/media-documents/media-document-
> audio-ios-sizing.html
> media/modern-media-controls/media-controller/ios/media-controller-ios-layout-
> traits-modern-compatibility-mode.html

Some of these look like they can be rebaselined for iPad (due to our desktop-class viewport adaptations, such as shrink-to-fit and ignoring the meta viewport tag by default).

The media controls tests might require a bit more digging.

[Wenson Hsieh]

Created attachment 371282 [details]
Replace useModernCompatibilityMode with contentMode

[Wenson Hsieh]

Created attachment 371286 [details]
Replace useModernCompatibilityMode with contentMode

[EWS Watchlist]

Comment on attachment 371286 [details]
Replace useModernCompatibilityMode with contentMode

Attachment 371286 [details] did not pass ios-sim-ews (ios-simulator-wk2):
Output: https://webkit-queues.webkit.org/results/12374065

New failing tests:
media/modern-media-controls/media-controller/ios/media-controller-ios-layout-traits-modern-compatibility-mode.html

[EWS Watchlist]

Created attachment 371299 [details]
Archive of layout-test-results from ews126 for ios-simulator-wk2

The attached test failures were seen while running run-webkit-tests on the ios-sim-ews.
Bot: ews126  Port: ios-simulator-wk2  Platform: Mac OS X 10.14.5

[Wenson Hsieh]

(In reply to Build Bot from comment #11)
> Comment on attachment 371286 [details]
> Replace useModernCompatibilityMode with contentMode
> 
> Attachment 371286 [details] did not pass ios-sim-ews (ios-simulator-wk2):
> Output: https://webkit-queues.webkit.org/results/12374065
> 
> New failing tests:
> media/modern-media-controls/media-controller/ios/media-controller-ios-layout-
> traits-modern-compatibility-mode.html

It looks like this caught an issue where the macOS flavor of modern media controls are used on open source iOS builds, after the code to support desktop content mode has been upstreamed into open source. In particular:

        // The window.navigator.platform !== "MacIntel" is strictly used for the test infrastructure since touch events are off for open-source bots.
        let traits = GestureRecognizer.SupportsTouches || window.navigator.platform !== "MacIntel" ? LayoutTraits.iOS : LayoutTraits.macOS;

...since SupportsTouches is false, yet navigator.platform is "MacIntel", LayoutTraits.macOS is used instead of LayoutTraits.iOS.

[Wenson Hsieh]

Created attachment 371406 [details]
Try to fix the media controls test

[WebKit Commit Bot]

Comment on attachment 371406 [details]
Try to fix the media controls test

Clearing flags on attachment: 371406

Committed r246118: <https://trac.webkit.org/changeset/246118>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.