The patch which introduced RenderThemeHaiku was wrong in some places. ( see: https://bugs.webkit.org/show_bug.cgi?id=28258#c5 ) Here is a patch to correct this. Regards, Maxime
Created attachment 34846 [details] Patch v1
Comment on attachment 34846 [details] Patch v1 r=me
Comment on attachment 34846 [details] Patch v1 Rejecting patch 34846 from commit-queue. This patch will require manual commit. Failed to run "['git', 'svn', 'dcommit']" exit_code: 1 cwd: None
Comment on attachment 34846 [details] Patch v1 Sorry, the commit-queue is dumb. There were 2 commits to the WebCore/ChangeLog between when the commit-queue updated and when it tried to commit. I'm about to teach it how to update itself before commit... bug 28316
(In reply to comment #4) > (From update of attachment 34846 [details]) > Sorry, the commit-queue is dumb. There were 2 commits to the WebCore/ChangeLog > between when the commit-queue updated and when it tried to commit. I'm about > to teach it how to update itself before commit... bug 28316 Okay. I didn't understand why it could fail as there was nothing "exotic" in this patch. But indeed bugzilla-tool is still in a learning phase. ;)
Comment on attachment 34846 [details] Patch v1 Clearing flags on attachment: 34846 Committing to http://svn.webkit.org/repository/webkit/trunk ... M WebCore/ChangeLog M WebCore/platform/haiku/RenderThemeHaiku.cpp M WebCore/platform/haiku/RenderThemeHaiku.h Committed r47296 M WebCore/ChangeLog M WebCore/platform/haiku/RenderThemeHaiku.cpp M WebCore/platform/haiku/RenderThemeHaiku.h r47296 = c0737da3bd221d15fd82b932dc33967859956e54 (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/47296
All reviewed patches have been landed. Closing bug.