Bug 28258 – [Haiku] Adding RenderTheme to WebCore.

• Status: RESOLVED
• Resolution: FIXED
• Component: WebCore Misc.

[Maxime Simon]

As I rewrote RenderThemeHaiku to have a header and the source code, I fill a new bug.

Regards,
Maxime

[Maxime Simon]

Created attachment 34738 [details]
Adding RenderTheme to WebCore.

[Eric Seidel (no email)]

Comment on attachment 34738 [details]
Adding RenderTheme to WebCore.

Looks OK.

This will error out if -wunused is on:
 41         virtual bool supportsHover(const RenderStyle* style) const { return false; }

not enough to warrant a re-review, but I expect you'll turn on -wunused like the rest of ports someday, so you'll want to fix that eventually.

[Eric Seidel (no email)]

Comment on attachment 34738 [details]
Adding RenderTheme to WebCore.

Clearing flags on attachment: 34738

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebCore/ChangeLog
	A	WebCore/platform/haiku/RenderThemeHaiku.cpp
	A	WebCore/platform/haiku/RenderThemeHaiku.h
Committed r47208
	M	WebKit/wx/ChangeLog
	M	WebKit/wx/wscript
r47207 = 4c9348ceea4c3eb1a46a5dd4f2ea2148685710fb (trunk)
	M	WebCore/ChangeLog
	A	WebCore/platform/haiku/RenderThemeHaiku.cpp
	A	WebCore/platform/haiku/RenderThemeHaiku.h
r47208 = 6b7214fbd718559f5efccb2dd9fc637de845ac7d (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/47208

[Eric Seidel (no email)]

All reviewed patches have been landed.  Closing bug.

[Maxime Simon]

(In reply to comment #2)
> (From update of attachment 34738 [details])
> This will error out if -wunused is on:
>  41         virtual bool supportsHover(const RenderStyle* style) const { return
> false; }

Actually, with the "-Wall" and "-Wextra" flags I didn't get the error you specified.
But when I merged this patch with the version of RenderThemeHaiku I have in my local branch, I got many problems. Looks like I posted the wrong patch ( an old version ).

I noticed things like:
- "RenderThemeHaiku::function(…" in the header,
- "virtual void RenderThemeHaiku::function(…" in the cpp file,
- or even "void function(…" in the cpp code for a method of the class.

Indeed I can promptly submit another patch to avoid these stupidities. But I should be blamed to not re-read attentively my patch before posting it.

Regards,
Maxime