Bug 28273 - [QT] revert the temporary S60 RVCT elftran workaround in qwebview.h when the right symbol is exported from Qt lib.
Summary: [QT] revert the temporary S60 RVCT elftran workaround in qwebview.h when the ...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Hardware S60 3rd edition
: P2 Minor
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 27065
  Show dependency treegraph
 
Reported: 2009-08-13 12:23 PDT by Yongjun Zhang
Modified: 2009-12-14 02:00 PST (History)
6 users (show)

See Also:


Attachments
Patch (1.54 KB, patch)
2009-12-12 16:19 PST, Simon Hausmann
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2009-08-13 12:23:08 PDT
A temporary fix is introduced in https://bugs.webkit.org/show_bug.cgi?id=28181; it should be reverted when the right symbol is exported.
Comment 1 Laszlo Gombos 2009-11-11 18:26:31 PST
Is this fix in Qt 4.6 now ? Is it time to revert ?
Comment 2 Simon Hausmann 2009-11-29 15:59:57 PST
(In reply to comment #1)
> Is this fix in Qt 4.6 now ? Is it time to revert ?

Yes, it's fixed in Qt 4.6 and the fix is part of Qt 4.6.0:

http://qt.gitorious.org/qt/qt/commit/8d0b487437e731ff3f5f97779002a4ffb48d92ec

Unfortunately we missed this revert in WebKit for 4.6.0, but we should still do it in the trunk of course :)
Comment 3 Simon Hausmann 2009-12-12 16:19:37 PST
Created attachment 44746 [details]
Patch
Comment 4 WebKit Review Bot 2009-12-12 16:22:50 PST
style-queue ran check-webkit-style on attachment 44746 [details] without any errors.
Comment 5 WebKit Commit Bot 2009-12-13 01:31:49 PST
Comment on attachment 44746 [details]
Patch

Clearing flags on attachment: 44746

Committed r52065: <http://trac.webkit.org/changeset/52065>
Comment 6 WebKit Commit Bot 2009-12-13 01:31:54 PST
All reviewed patches have been landed.  Closing bug.
Comment 7 Simon Hausmann 2009-12-14 02:00:28 PST
I was talking rubbish: Of course we can include this in 4.6.x, as it doesn not affect the number of exported symbols at all.

Cherry-picked as commit 488a95f395a49bdd781d878891b45c61b450404a