Bug 28181 - RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView::RenderHints property.
Summary: RVCT elftran fails to resolve QPainter::staticMetaObject coming with QWebView...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit Qt (show other bugs)
Version: 528+ (Nightly build)
Hardware: S60 Emulator S60 3rd edition
: P2 Normal
Assignee: Nobody
URL:
Keywords: Qt
Depends on:
Blocks: 27065
  Show dependency treegraph
 
Reported: 2009-08-11 10:41 PDT by Yongjun Zhang
Modified: 2009-08-14 07:50 PDT (History)
3 users (show)

See Also:


Attachments
don't use RenderHint property when building for symbian. (1.45 KB, patch)
2009-08-11 11:30 PDT, Yongjun Zhang
eric: review-
Details | Formatted Diff | Diff
Modified patch as per Eric's comments. (1.67 KB, patch)
2009-08-13 12:31 PDT, Yongjun Zhang
eric: review-
Details | Formatted Diff | Diff
Remove tab in previous patch (bad copy&paste habbit :) ) (1.69 KB, patch)
2009-08-13 12:50 PDT, Yongjun Zhang
hausmann: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Yongjun Zhang 2009-08-11 10:41:21 PDT
QWebView::RenderHints property makes QWebView::staticMetaObject depends on QPainter::staticMetaObject with breaks RVCT elftran linking.

We have to remove this property now, until the right symbol is exported.
Comment 1 Yongjun Zhang 2009-08-11 11:30:16 PDT
Created attachment 34579 [details]
don't use RenderHint property when building for symbian. 

It is a temporary fix, should be reverted when the right symbol is exported from QT lib.
Comment 2 Eric Seidel (no email) 2009-08-11 22:34:14 PDT
Comment on attachment 34579 [details]
don't use RenderHint property when building for symbian. 

The code you're adding should have a FIXME explaining the temporary nature.
Comment 3 Eric Seidel (no email) 2009-08-11 22:34:35 PDT
You also should file a bug about backing this out (and ideally link to it from your FIXME)
Comment 4 Yongjun Zhang 2009-08-13 12:31:23 PDT
Created attachment 34771 [details]
Modified patch as per Eric's comments.

Thanks for the quick review.

I modified the patch as suggested in the comments:

1. created a bug (https://bugs.webkit.org/show_bug.cgi?id=28273) to remind me to revert the change later.
2. added //FIXME comment and link to the above bug.
Comment 5 Eric Seidel (no email) 2009-08-13 12:40:04 PDT
Comment on attachment 34771 [details]
Modified patch as per Eric's comments.

Tab in ChangeLog.  r- as that will fail to land.

So is there a bug with upstream Qt about getting this resolved?  OR does nokia build some custom S60 Qt, and thus the bug would be with Nokia?
Comment 6 Yongjun Zhang 2009-08-13 12:50:30 PDT
Created attachment 34773 [details]
Remove tab in previous patch (bad copy&paste habbit :) )

This bug will be fixed in upstream Qt for S60.  This is a temporary fix to make webkit build with current Qt 4.5.2 for S60.
Comment 7 Eric Seidel (no email) 2009-08-13 13:13:14 PDT
Do we have a bug number for the upstream fix?
Comment 8 Simon Hausmann 2009-08-13 13:52:00 PDT
Good point Eric, there is a bug number. I'll dig it out tomorrow.
Comment 9 Eric Seidel (no email) 2009-08-13 13:53:12 PDT
Thank you.  I just figure it's best that we get all the documentation in the right place now, while we're making the change, instead of 3 years from now, when we're wondering if we can back it out or not. ;)
Comment 10 Simon Hausmann 2009-08-14 01:34:30 PDT
The upstream bug report in Qt is tracked at http://qt.nokia.com/developer/task-tracker/index_html?method=entry&id=258893
Comment 11 Simon Hausmann 2009-08-14 07:48:41 PDT
Comment on attachment 34773 [details]
Remove tab in previous patch (bad copy&paste habbit :) )

r=me

I'll change the url in the comment to the upstream bug url when landing.
Comment 12 Simon Hausmann 2009-08-14 07:50:33 PDT
Landed in r47285