RESOLVED FIXED280886
[JHBuild] Add libspiel to minimal moduleset 
https://bugs.webkit.org/show_bug.cgi?id=280886
Summary [JHBuild] Add libspiel to minimal moduleset
Diego Pino
Reported 2024-10-04 07:02:33 PDT
Changeset 284276@main change speech synthesis from experimental feature to always on. It also changed the speech synthesis backend, from flite2 to libspiel. Libspiel is not packaged in any distro yet. Since the feature was removed from experimental features, the Ubuntu and Debian upstream fails failed after 284276@main. The work around the build failure we disbaledspeech synthesis in the bots (-DENABLE_SPEECH_SYNTHESIS=OFF). Since speech synthesis is always on now, support for `libspiel` should be added to JHBuild minimal moduleset, for users that would like to build with this build system.
Attachments
Add attachment proposed patch, testcase, etc.
Diego Pino
Comment 1 2024-10-04 07:06:22 PDT
Pull request: https://github.com/webkit/webkit/pull/34696
EWS
Comment 2 2024-10-07 05:23:14 PDT
Committed 284758@main (30c09a60fec7): <https://commits.webkit.org/284758@main> Reviewed commits have been landed. Closing PR #34696 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2024-10-07 05:24:14 PDT
<rdar://problem/137420202>
WebKit Commit Bot
Comment 4 2024-10-13 04:51:31 PDT
Re-opened since this is blocked by bug 281397
Diego Pino
Comment 5 2024-10-23 03:36:34 PDT
After 285005@main, Libspiel is now optional and it's no longer strictly needed to enable SPEECH_SYNTHESIS. That funcionality is implemented by default by a different backend, Flite2, which is available in every major Linux distribution.
Note You need to log in before you can comment on or make changes to this bug.