Bug 28065 - Inherit Noncopyable publicly
Summary: Inherit Noncopyable publicly
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 27879
  Show dependency tree / graph
 
Reported: 2009-08-07 01:44 PDT by Zoltan Horvath
Modified: 2009-09-01 23:51 PDT (History)
0 users

See Also:

Attachments
proposed patch (2.75 KB, patch)
2009-08-07 01:44 PDT, Zoltan Horvath 		no flags Details | Formatted Diff | Diff
updated proposed patch (2.75 KB, patch)
2009-08-07 01:52 PDT, Zoltan Horvath 		eric: review-
Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-08-07 01:44:20 PDT 
Since Noncopyable'll be inherited from FastAllocBase, Noncopyable's inheriting has to be changed to public.
Comment 1 Zoltan Horvath 2009-08-07 01:44:57 PDT 
Created attachment 34259 [details]
proposed patch
Comment 2 Zoltan Horvath 2009-08-07 01:52:39 PDT 
Created attachment 34260 [details]
updated proposed patch
Comment 3 Eric Seidel (no email) 2009-08-07 08:36:10 PDT 
Comment on attachment 34260 [details]
updated proposed patch

Why?  So that new/delete work?  Need a couple more words in your ChangeLog. :)

Is this all the instances of non-public Noncopybable inheritance?
Comment 4 Zoltan Horvath 2009-08-10 05:58:55 PDT 
These classes aren't instantiated by new, after all don't need to inherit from publicly from Noncopyable.

I tried to follow changes that have been done in bug #27225 .
Comment 5 Zoltan Horvath 2009-09-01 23:51:30 PDT 
So, this patch contains unnecessary changes. I mark it as invalid.