RESOLVED FIXED Bug 27225
Change all Noncopyable inheriting to publicly inheriting 
https://bugs.webkit.org/show_bug.cgi?id=27225
Summary Change all Noncopyable inheriting to publicly inheriting
Zoltan Horvath
Reported 2009-07-13 11:28:41 PDT
Noncopyable will be inherited from FastAllocBase (I'll file another bug), so all of Noncopyable inheriting visibility have to change to public. (There is no reason to use private inheritance, but now it's reasonable to change it to public.)
Attachments
proposed patch (76.59 KB, patch)
2009-07-13 11:44 PDT, Zoltan Horvath 		darin: review-
DetailsFormatted DiffDiff
updated proposed patch (62.50 KB, patch)
2009-07-14 16:08 PDT, Zoltan Horvath 		darin: review+
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Zoltan Horvath
Comment 1 2009-07-13 11:44:18 PDT
Created attachment 32668 [details] proposed patch
Darin Adler
Comment 2 2009-07-14 15:34:20 PDT
Comment on attachment 32668 [details] proposed patch > -struct OpaqueJSClassContextData : Noncopyable { > +struct OpaqueJSClassContextData : public Noncopyable { struct inheritance is already public, so this change is not needed. There are tons of other cases like this. Please don't make those changes since they aren't needed. Otherwise this seems fine. review- because I'd like to see the patch without the unneeded changes.
Zoltan Horvath
Comment 3 2009-07-14 16:08:46 PDT
Created attachment 32745 [details] updated proposed patch I've updated the patch and removed the unnecessary struct changes.
Brent Fulgham
Comment 4 2009-07-14 22:19:31 PDT
Landed in http://trac.webkit.org/changeset/45891.
Note You need to log in before you can comment on or make changes to this bug.