Bug 27225 - Change all Noncopyable inheriting to publicly inheriting
Summary: Change all Noncopyable inheriting to publicly inheriting
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
Depends on:
Blocks: 27248
  Show dependency treegraph
Reported: 2009-07-13 11:28 PDT by Zoltan Horvath
Modified: 2009-07-14 22:19 PDT (History)
2 users (show)

See Also:

proposed patch (76.59 KB, patch)
2009-07-13 11:44 PDT, Zoltan Horvath
darin: review-
Details | Formatted Diff | Diff
updated proposed patch (62.50 KB, patch)
2009-07-14 16:08 PDT, Zoltan Horvath
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Zoltan Horvath 2009-07-13 11:28:41 PDT
Noncopyable will be inherited from FastAllocBase (I'll file another bug), so all of Noncopyable inheriting visibility have to change to public. (There is no reason to use private inheritance, but now it's reasonable to change it to public.)
Comment 1 Zoltan Horvath 2009-07-13 11:44:18 PDT
Created attachment 32668 [details]
proposed patch
Comment 2 Darin Adler 2009-07-14 15:34:20 PDT
Comment on attachment 32668 [details]
proposed patch

> -struct OpaqueJSClassContextData : Noncopyable {
> +struct OpaqueJSClassContextData : public Noncopyable {

struct inheritance is already public, so this change is not needed. There are tons of other cases like this. Please don't make those changes since they aren't needed. Otherwise this seems fine. review- because I'd like to see the patch without the unneeded changes.
Comment 3 Zoltan Horvath 2009-07-14 16:08:46 PDT
Created attachment 32745 [details]
updated proposed patch

I've updated the patch and removed the unnecessary struct changes.
Comment 4 Brent Fulgham 2009-07-14 22:19:31 PDT
Landed in http://trac.webkit.org/changeset/45891.