RESOLVED FIXED Bug 280125
[CMake] ENABLE_LAYOUT_TESTS should depend on DEVELOPER_MODE 
https://bugs.webkit.org/show_bug.cgi?id=280125
Summary [CMake] ENABLE_LAYOUT_TESTS should depend on DEVELOPER_MODE
Adrian Perez
Reported 2024-09-21 09:17:53 PDT
When ENABLE_LAYOUT_TESTS is enabled the CMake build compiles WKTR. But WKTR uses internal functions from Web{Core,Kit}, which are hidden by a linker script *unless* DEVELOPER_MODE is enabled. Currently it's possible to set ENABLE_LAYOUT_TESTS=ON with DEVELOPER_MODE=OFF and the build will fail to link WKTR. It would be better to prevent this set of config options to work together.
Attachments
Add attachment proposed patch, testcase, etc.
Adrian Perez
Comment 1 2024-09-23 15:33:36 PDT
Pull request: https://github.com/WebKit/WebKit/pull/34118
EWS
Comment 2 2024-09-24 00:33:36 PDT
Committed 284143@main (a3074bfed0e7): <https://commits.webkit.org/284143@main> Reviewed commits have been landed. Closing PR #34118 and removing active labels.
Note You need to log in before you can comment on or make changes to this bug.