Bug 202345 - [WPE][GTK] Allow running as many tests as possible from tarball builds
Summary: [WPE][GTK] Allow running as many tests as possible from tarball builds
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: CMake (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Linux
: P3 Normal
Assignee: Michael Catanzaro
URL:
Keywords: Gtk
: 210001 (view as bug list)
Depends on:
Blocks:
 
Reported: 2019-09-28 08:48 PDT by Tomasz Kłoczko
Modified: 2020-04-04 07:01 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Tomasz Kłoczko 2019-09-28 08:48:20 PDT 
Looks like test suite is not updated or some files are missing in dist tar ball.

+ /usr/bin/ninja check -v -j48
[1/1] cd /home/tkloczko/rpmbuild/BUILD/webkitgtk-2.26.1 && /home/tkloczko/rpmbuild/BUILD/webkitgtk-2.26.1/Tools/Scripts/run-gtk-tests
FAILED: Source/CMakeFiles/check 
cd /home/tkloczko/rpmbuild/BUILD/webkitgtk-2.26.1 && /home/tkloczko/rpmbuild/BUILD/webkitgtk-2.26.1/Tools/Scripts/run-gtk-tests
/bin/sh: /home/tkloczko/rpmbuild/BUILD/webkitgtk-2.26.1/Tools/Scripts/run-gtk-tests: No such file or directory
ninja: build stopped: subcommand failed.
Comment 1 Michael Catanzaro 2019-09-29 09:57:07 PDT 
The testsuite isn't designed to be run from tarballs, and it hasn't passed in years anyway.

I guess the bug here is that the check target is not disabled, it should be dependent on ENABLE_DEVELOPER_MODE.
Comment 2 Tomasz Kłoczko 2019-10-04 09:57:24 PDT 
Just tested 2.27.1 and looks like still it is not possible to build it as long as LTO optimisation is in use.
Comment 3 Tomasz Kłoczko 2019-10-04 10:01:50 PDT 
Please ignore last comment.
I've added it under wrong ticket.
Comment 4 Tomasz Kłoczko 2020-04-03 23:17:35 PDT 
*** Bug 210001 has been marked as a duplicate of this bug. ***
Comment 5 Tomasz Kłoczko 2020-04-03 23:22:38 PDT 
So webkit test suite cannot be used on building release binaries?
Comment 6 Michael Catanzaro 2020-04-04 07:00:41 PDT 
Not currently. Fixing this is on my TODO, but no promises when I'll get to it.