Bug 28008 - fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay
: fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Tools / Tests
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To: Nobody
:
Depends on:
Blocks: 27995
  Show dependency treegraph
 
Reported: 2009-08-04 18:14 PDT by Eric Seidel
Modified: 2009-08-05 00:32 PDT (History)
0 users

See Also:


Attachments
Patch v1 (11.71 KB, patch)
2009-08-04 18:16 PDT, Eric Seidel
simon.fraser: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel 2009-08-04 18:14:36 PDT
fast/forms/textfield-drag-into-disabled.html has a needless 5 second delay

This layout test is from another era.  I've updated it to be dumpAsText and not need a 5-second delay to test dragging.  I validated that I didn't break the test by temporarily removing the "disabled" flag from the <input> and checking that the drag succeeded (i.e. the test failed) with disabled removed.
Comment 1 Eric Seidel 2009-08-04 18:16:27 PDT
Created attachment 34106 [details]
Patch v1
Comment 2 Eric Seidel 2009-08-04 18:34:49 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	D	LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum
	D	LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.png
	D	LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt
	D	LayoutTests/platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt
	D	LayoutTests/platform/win/fast/forms/textfield-drag-into-disabled-expected.txt
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/forms/textfield-drag-into-disabled-expected.txt
	M	LayoutTests/fast/forms/textfield-drag-into-disabled.html
Committed r46790
	D	LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.txt
	D	LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.png
	D	LayoutTests/platform/mac/fast/forms/textfield-drag-into-disabled-expected.checksum
	D	LayoutTests/platform/qt/fast/forms/textfield-drag-into-disabled-expected.txt
	D	LayoutTests/platform/win/fast/forms/textfield-drag-into-disabled-expected.txt
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/forms/textfield-drag-into-disabled-expected.txt
	M	LayoutTests/fast/forms/textfield-drag-into-disabled.html
r46790 = 0e2037c9047382a8aee9bdbd132f550c58725acd (trunk)
No changes between current HEAD and refs/remotes/trunk
Resetting to the latest refs/remotes/trunk
http://trac.webkit.org/changeset/46790
Comment 3 Mark Rowe (bdash) 2009-08-05 00:32:10 PDT
Another good example of why bug 26920 should be addressed.