Bug 277299 - WebCore::Timer should assert that web thread lock is held or the web thread is disabled
Summary: WebCore::Timer should assert that web thread lock is held or the web thread i...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Ryosuke Niwa
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-07-29 16:40 PDT by Ryosuke Niwa
Modified: 2024-07-30 16:28 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ryosuke Niwa 2024-07-29 16:40:40 PDT 
WebCore::Timer should assert that the web thread lock is held or the web thread is disabled.
Comment 1 Ryosuke Niwa 2024-07-29 16:46:17 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/31423
Comment 2 David Kilzer (:ddkilzer) 2024-07-30 11:12:04 PDT 
See also:

Bug 168008: Audit WebCore uses of RunLoop::main for USE(WEB_THREAD) iOS WebKit1
<https://bugs.webkit.org/show_bug.cgi?id=168008>

Bug 172390: [iOS]: RunLoop::main().dispatch() needs to take into account USE_WEB_THREAD
<https://bugs.webkit.org/show_bug.cgi?id=172390>

Bug 233967: Add a version of ThreadAssertions that treats UI and Web thread as the same
<https://bugs.webkit.org/show_bug.cgi?id=233967>
Comment 3 David Kilzer (:ddkilzer) 2024-07-30 11:14:41 PDT 
This is basically a dupe of this:

Bug 185330: [iOS] Add assert to catch improper use of WebCore::Timer in UI Process
<https://bugs.webkit.org/show_bug.cgi?id=185330>
Comment 4 EWS 2024-07-30 16:27:35 PDT 
Committed 281614@main (a01578c7c53b): <https://commits.webkit.org/281614@main>

Reviewed commits have been landed. Closing PR #31423 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2024-07-30 16:28:13 PDT 
<rdar://problem/132854744>