WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
NEW
168008
Audit WebCore uses of RunLoop::main for USE(WEB_THREAD) iOS WebKit1
https://bugs.webkit.org/show_bug.cgi?id=168008
Summary
Audit WebCore uses of RunLoop::main for USE(WEB_THREAD) iOS WebKit1
Joseph Pecoraro
Reported
2017-02-08 11:36:47 PST
Audit WebCore uses of RunLoop::main for USE(WEB_THREAD) iOS WebKit1 Seems like these would need to handle iOS WebKit's WebThread. bindings/js/SerializedScriptValue.cpp 2912: RunLoop::main().dispatch([this, conditionPtr = &condition, valuePtr = &value] { inspector/WebHeapAgent.cpp 57: , m_timer(RunLoop::main(), this, &SendGarbageCollectionEventsTask::timerFired) Modules/applepay/ApplePaySession.cpp 496: RunLoop::main().dispatch([promise, canMakePayments]() mutable { Modules/websockets/WebSocket.cpp 295: RunLoop::main().dispatch([this, protectedThis = makeRef(*this)]() { platform/graphics/MediaPlaybackTargetPicker.cpp 40: , m_pendingActionTimer(RunLoop::main(), this, &MediaPlaybackTargetPicker::pendingActionTimerFired) workers/WorkerMessagingProxy.cpp 165: RunLoop::main().dispatch([this, message = message.isolatedCopy()] { This is code in WebCore that stays in WebCore, so probably needs a WebThreadLock for legacy WebKit.
Attachments
Add attachment
proposed patch, testcase, etc.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug