Bug 27676 - [WML] WMLDoElement doesn't update its RenderButton object upon attach()
Summary: [WML] WMLDoElement doesn't update its RenderButton object upon attach()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nikolas Zimmermann
URL:
Keywords:
Depends on:
Blocks: 20393 27677
  Show dependency tree / graph
 
Reported: 2009-07-25 05:26 PDT by Nikolas Zimmermann
Modified: 2009-07-25 09:35 PDT (History)
1 user (show)

See Also:

Attachments
Initial patch (9.62 KB, patch)
2009-07-25 05:38 PDT, Nikolas Zimmermann 		staikos: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Nikolas Zimmermann 2009-07-25 05:26:11 PDT 
WMLDoElement doesn't fire updateFromElement() calls in attach(), unlike HTMLButtonElement (which achieves this functionality by it's super-class HTMLFormControlElement). Fix that.

Solves some style problems, and layout test dump results.
Comment 1 Nikolas Zimmermann 2009-07-25 05:38:00 PDT 
Created attachment 33492 [details]
Initial patch
Comment 2 Nikolas Zimmermann 2009-07-25 09:35:32 PDT 
Sending        LayoutTests/ChangeLog
Sending        LayoutTests/platform/mac/fast/wml/do-element-optional-attr-expected.txt
Sending        LayoutTests/platform/mac/fast/wml/do-shadow-expected.txt
Sending        LayoutTests/platform/mac/fast/wml/do-template-expected.txt
Sending        LayoutTests/platform/mac/fast/wml/err-invalid-location-for-varref-expected.txt
Sending        LayoutTests/platform/mac/fast/wml/err-invalid-variable-name-expected.txt
Sending        LayoutTests/platform/mac/fast/wml/err-samename-do-expected.txt
Sending        WebCore/ChangeLog
Sending        WebCore/wml/WMLDoElement.cpp
Sending        WebCore/wml/WMLDoElement.h
Transmitting file data ..........
Committed revision 46394.
http://trac.webkit.org/changeset/46394