Bug 275811 - [Win] Use SystemV ABI for Wasm LLInt on Windows
Summary: [Win] Use SystemV ABI for Wasm LLInt on Windows
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Windows 10
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-06-24 07:47 PDT by Ian Grunert
Modified: 2024-06-25 08:17 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Grunert 2024-06-24 07:47:13 PDT 
clang-cl gives us the option of changing a function to use the SystemV ABI:

https://clang.llvm.org/docs/AttributeReference.html#sysv-abi

By using this on functions on the C++ / JIT boundaries, we can use the same codepaths for function calls and the same register mappings between Windows and Linux / Mac / BSD.

JS LLInt was completed in bug 274064 and Baseline JIT in bug 275213 so there's no blockers for this.
Comment 1 Ian Grunert 2024-06-24 20:11:30 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/30116
Comment 2 EWS 2024-06-25 08:16:19 PDT 
Committed 280334@main (e65584915c8f): <https://commits.webkit.org/280334@main>

Reviewed commits have been landed. Closing PR #30116 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-06-25 08:17:15 PDT 
<rdar://problem/130505394>