Bug 274064 - [Win] Use SystemV ABI for C++ entrypoints for JS LLInt
Summary: [Win] Use SystemV ABI for C++ entrypoints for JS LLInt
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: JavaScriptCore (show other bugs)
Version: WebKit Nightly Build
Hardware: PC Windows 10
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-05-12 17:53 PDT by Ian Grunert
Modified: 2024-05-18 18:27 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Ian Grunert 2024-05-12 17:53:07 PDT 
clang-cl gives us the option of changing a function to use the SystemV ABI:

https://clang.llvm.org/docs/AttributeReference.html#sysv-abi

By using this on functions on the C++ / JIT boundaries, we can use the same codepaths for function calls and the same register mappings between Windows and Linux / Mac / BSD.
Comment 1 Ian Grunert 2024-05-17 12:13:48 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/28723
Comment 2 EWS 2024-05-18 18:26:40 PDT 
Committed 278967@main (8f1711cf5f78): <https://commits.webkit.org/278967@main>

Reviewed commits have been landed. Closing PR #28723 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-05-18 18:27:16 PDT 
<rdar://problem/128339579>