Bug 27526 – Inspector: Removing an Attribute via Edit should Delete the Attribute, Not Ignore Your Changes

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Web Inspector (Deprecated)

[Joseph Pecoraro]

This decision must have been made in the past.  When editing an element's attribute in the Element Panel's Tree, if you remove all of the text and commit the change, your changes are ignored.  I would have expected this to remove the attribute.  Was there a good reason for this?  Was it to prevent accidental errors?  Otherwise there is no way to remove an attribute via the tree (you can always use the console).

[Joseph Pecoraro]

Created attachment 33231 [details]
Removing an Attribute Deletes the Attribute - And Fix Possible Exception

NOTES:

1. This will delete an attribute _if_ that attribute previously existed.  The only time an attribute would not previously exist would be if it is a "new" attribute.  This means this is compatible with the (uncommitted) patch on the following bug to create new attributes:
https://bugs.webkit.org/show_bug.cgi?id=21108

2. This fixes an error that has been around for a while where an invalid attribute from user input (such as "-") can cause an error.  An example test case will be attached in a minute.

[Joseph Pecoraro]

Created attachment 33232 [details]
Example Page Showing the Caught Error

This shows why the try/catch fixes an error. If the user edits an attribute and changes all the text to "-" the innerHTML works fine but the setAttribute() would throw an Error.

[Adam Barth]

Comment on attachment 33231 [details]
Removing an Attribute Deletes the Attribute - And Fix Possible Exception

This patch does not apply cleanly to TOT.  I haven't looked whether the merge is trivial.

[Joseph Pecoraro]

Created attachment 33439 [details]
Applies to ToT

- Fixed a Style Issue as well

[Joseph Pecoraro]

Comment on attachment 33439 [details]
Applies to ToT

I added this functionality into bug 27673, which does more and includes this feature.

[Joseph Pecoraro]

*** This bug has been marked as a duplicate of bug 27673 ***