RESOLVED FIXED27403
Add test case for bug 27394
https://bugs.webkit.org/show_bug.cgi?id=27403
Summary Add test case for bug 27394
Mads Ager
Reported 2009-07-17 18:49:09 PDT
Adding a reduced layout test for: https://bugs.webkit.org/show_bug.cgi?id=27394 Properties on a window object should be accessible after the frame of the window object has navigated to another page. In particular, they should be accessible even if the new page does not contain JavaScript code. Since I don't want JavaScript on the new page I'm using a polling approach in the test.
Attachments
Layout test for window access after navigation. (2.64 KB, patch)
2009-07-17 18:50 PDT, Mads Ager
no flags
Layout test for window access after navigation. (2.65 KB, patch)
2009-07-17 18:56 PDT, Mads Ager
no flags
Layout test for window access after navigation. (2.65 KB, patch)
2009-07-17 19:02 PDT, Mads Ager
abarth: review-
Use onload instead of polling (2.47 KB, patch)
2009-07-17 19:44 PDT, Mads Ager
abarth: review+
Mads Ager
Comment 1 2009-07-17 18:50:10 PDT
Created attachment 32998 [details] Layout test for window access after navigation.
Mads Ager
Comment 2 2009-07-17 18:56:37 PDT
Created attachment 32999 [details] Layout test for window access after navigation. Test for 'blank.html' instead of just 'blank' to avoid matching 'about:blank'.
Mads Ager
Comment 3 2009-07-17 19:02:32 PDT
Created attachment 33000 [details] Layout test for window access after navigation. And fixing the ChangeLog with the right bug number. Sorry about the spam.
Adam Barth
Comment 4 2009-07-17 19:15:52 PDT
Comment on attachment 33000 [details] Layout test for window access after navigation. Please don't use polling. Use the frame's load event instead.
Mads Ager
Comment 5 2009-07-17 19:44:34 PDT
Created attachment 33003 [details] Use onload instead of polling Thanks, onload is better.
Adam Barth
Comment 6 2009-07-17 20:19:42 PDT
Comment on attachment 33003 [details] Use onload instead of polling This looks great! Thanks for the patch.
Adam Barth
Comment 7 2009-07-17 20:21:25 PDT
Will land.
Adam Barth
Comment 8 2009-07-17 22:33:09 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ... M LayoutTests/ChangeLog A LayoutTests/fast/dom/Window/window-access-after-navigation-expected.txt A LayoutTests/fast/dom/Window/window-access-after-navigation.html Committed r46083 M LayoutTests/ChangeLog A LayoutTests/fast/dom/Window/window-access-after-navigation-expected.txt A LayoutTests/fast/dom/Window/window-access-after-navigation.html r46083 = 4cfb777d8fcab32107f6eea1ed7adf912803175f (trunk) No changes between current HEAD and refs/remotes/trunk Resetting to the latest refs/remotes/trunk http://trac.webkit.org/changeset/46083
Note You need to log in before you can comment on or make changes to this bug.