Bug 27394 - V8: Selenium test failures
Summary: V8: Selenium test failures
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-17 15:53 PDT by Mads Ager
Modified: 2009-07-17 17:24 PDT (History)
3 users (show)

See Also:


Attachments
Fix global access after navigation (1.45 KB, patch)
2009-07-17 15:55 PDT, Mads Ager
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Mads Ager 2009-07-17 15:53:22 PDT
After 

http://trac.webkit.org/changeset/45797

there are new selenium test failures using WebCore/V8.

If javascript code holds a reference to the global object of a frame we need to eagerly initialize the JavaScript context when a new document is loaded in that frame to allow access to properties of that global object.  This kind of pattern is used in selenium tests to detect page loads.

Patch coming up.
Comment 1 Mads Ager 2009-07-17 15:55:47 PDT
Created attachment 32986 [details]
Fix global access after navigation
Comment 2 Dimitri Glazkov (Google) 2009-07-17 16:01:42 PDT
Comment on attachment 32986 [details]
Fix global access after navigation

ok
Comment 3 Sam Weinig 2009-07-17 16:39:54 PDT
Is there at test that can be added to the test suite for this bug fix?
Comment 4 Mads Ager 2009-07-17 16:50:41 PDT
Yes, you are right.  I should add a layout test with a reduced test case.  Let me put something together and upload that as a separate patch.
Comment 5 Eric Roman 2009-07-17 17:12:58 PDT
Landed r46073.