Bug 271808 – compile-webkit step reported success even though xcodebuild couldn't find the specified platform

• Status: NEW
• Component: Tools / Tests

[Ryan Haddad]

In https://build.webkit.org/#/builders/943/builds/6239, the bot running the build was missing iOS simulator runtimes. xcodebuild threw an error about the missing platform, but build-webkit exited with rc=0, which kicked off archive upload and triggered tests with a bad build artifact.


/bin/sh -c 'perl Tools/Scripts/build-webkit --no-fatal-warnings --release --architecture "x86_64 arm64" WK_VALIDATE_DEPENDENCIES=YES DEBUG_INFORMATION_FORMAT=dwarf-with-dsym CLANG_DEBUG_INFORMATION_LEVEL=\$\(WK_OVERRIDE_DEBUG_INFORMATION_LEVEL:default=line-tables-only\) --ios-simulator 2>&1 | perl Tools/Scripts/filter-build-webkit -logfile build-log.txt'

xcodebuild: error: Unable to find a destination matching the provided destination specifier:
		{ generic:1, platform:iOS Simulator }
	Available destinations for the "Everything up to WebKit + Tools" scheme:
		{ platform:macOS, arch:arm64, id:00008103-0019644E22FB001E, name:My Mac }
		{ platform:macOS, arch:x86_64, id:00008103-0019644E22FB001E, name:My Mac }
		{ platform:macOS, arch:arm64, variant:Mac Catalyst, id:00008103-0019644E22FB001E, name:My Mac }
		{ platform:macOS, arch:x86_64, variant:Mac Catalyst, id:00008103-0019644E22FB001E, name:My Mac }
		{ platform:macOS, name:Any Mac }
		{ platform:macOS, variant:Mac Catalyst, name:Any Mac }
		{ platform:tvOS, id:dvtdevice-DVTiOSDevicePlaceholder-appletvos:placeholder, name:Any tvOS Device }
		{ platform:tvOS Simulator, id:dvtdevice-DVTiOSDeviceSimulatorPlaceholder-appletvsimulator:placeholder, name:Any tvOS Simulator Device }
		{ platform:visionOS, id:dvtdevice-DVTiOSDevicePlaceholder-xros:placeholder, name:Any visionOS Device }
		{ platform:visionOS Simulator, id:dvtdevice-DVTiOSDeviceSimulatorPlaceholder-xrsimulator:placeholder, name:Any visionOS Simulator Device }
		{ platform:tvOS Simulator, id:E68FB313-E711-4163-A421-02E937D93174, OS:17.4, name:Apple TV }
		{ platform:tvOS Simulator, id:E68FB313-E711-4163-A421-02E937D93174, OS:17.4, name:Apple TV }
		{ platform:tvOS Simulator, id:7124D662-D7F6-44D0-AD3E-9246CCC3FE70, OS:17.4, name:Apple TV 4K (3rd generation) }
		{ platform:tvOS Simulator, id:7124D662-D7F6-44D0-AD3E-9246CCC3FE70, OS:17.4, name:Apple TV 4K (3rd generation) }
		{ platform:tvOS Simulator, id:66863B03-9988-40E6-92A2-5A5D0EB5C279, OS:17.4, name:Apple TV 4K (3rd generation) (at 1080p) }
		{ platform:tvOS Simulator, id:66863B03-9988-40E6-92A2-5A5D0EB5C279, OS:17.4, name:Apple TV 4K (3rd generation) (at 1080p) }
		{ platform:visionOS Simulator, id:33B208B2-432C-4FB4-A089-579C544015B8, OS:1.1, name:Apple Vision Pro }
	Ineligible destinations for the "Everything up to WebKit + Tools" scheme:
		{ platform:iOS, id:dvtdevice-DVTiPhonePlaceholder-iphoneos:placeholder, name:Any iOS Device, error:iOS 17.4 is not installed. To use with Xcode, first download and install the platform }
		{ platform:watchOS, id:dvtdevice-DVTiOSDevicePlaceholder-watchos:placeholder, name:Any watchOS Device, error:watchOS 10.4 is not installed. To use with Xcode, first download and install the platform }
program finished with exit code 0

[Radar WebKit Bug Importer]

<rdar://problem/125515573>

[Elliott Williams]

> /bin/sh -c 'perl Tools/Scripts/build-webkit --no-fatal-warnings --release --architecture "x86_64 arm64" WK_VALIDATE_DEPENDENCIES=YES DEBUG_INFORMATION_FORMAT=dwarf-with-dsym CLANG_DEBUG_INFORMATION_LEVEL=\$\(WK_OVERRIDE_DEBUG_INFORMATION_LEVEL:default=line-tables-only\) --ios-simulator 2>&1 | perl Tools/Scripts/filter-build-webkit -logfile build-log.txt'

The exit code will be from the last command in the pipeline, so https://bugs.webkit.org/show_bug.cgi?id=270807 ([build.webkit.org] Upload WebKit build logs to s3) may be the cause. build-webkit is correctly failing, but buildbot only sees the exit code of filter-build-webkit.

Not sure if buildbot has a built-in way to express this, or if we should just add "; exit ${PIPESTATUS[0]}" to the end.

[Brianna Fan]

Pull request: https://github.com/WebKit/WebKit/pull/29792

[Ryan Haddad]

*** Bug 283597 has been marked as a duplicate of this bug. ***