WebKit Bugzilla
New
Browse
Search+
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
271719
Output better metadata for baseline_search_path and expectations_files
https://bugs.webkit.org/show_bug.cgi?id=271719
Summary
Output better metadata for baseline_search_path and expectations_files
Sam Sneddon [:gsnedders]
Reported
2024-03-26 12:47:34 PDT
We should include expectations_files in full_results.json, and output the expectations files path alongside the baseline search path (this has caused confusion before, c.f.
https://bugs.webkit.org/show_bug.cgi?id=105583#c13
), and if we ever want to get rid of the version-specific expectations files (
Bug 271331
) we need to be outputting this to avoid confusion. We should also be using some device_type we're actually running, and not None, when calculating the values for full_results.json (we have to choose one, because we have no means to easily segment the data based on device_type without breaking compatibility with every system that consumes these files).
Attachments
Add attachment
proposed patch, testcase, etc.
Sam Sneddon [:gsnedders]
Comment 1
2024-03-26 12:50:25 PDT
Pull request:
https://github.com/WebKit/WebKit/pull/26476
EWS
Comment 2
2024-03-26 20:29:16 PDT
Committed
276719@main
(aacb258efde8): <
https://commits.webkit.org/276719@main
> Reviewed commits have been landed. Closing PR #26476 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2024-03-26 20:30:16 PDT
<
rdar://problem/125457720
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug