Bug 271331 - Get rid of version-specific TestExpectations files
Summary: Get rid of version-specific TestExpectations files
Status: NEW
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks:
 
Reported: 2024-03-20 12:26 PDT by Sam Sneddon [:gsnedders]
Modified: 2024-03-20 12:26 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Sneddon [:gsnedders] 2024-03-20 12:26:20 PDT 
Currently we have:

LayoutTests/platform/mac-monterey-wk1/TestExpectations
LayoutTests/platform/mac-monterey-wk2/TestExpectations
LayoutTests/platform/mac-monterey/TestExpectations
LayoutTests/platform/mac-sonoma-wk2-lbse-text/TestExpectations
LayoutTests/platform/mac-ventura-wk1/TestExpectations
LayoutTests/platform/mac-ventura-wk2/TestExpectations
LayoutTests/platform/mac-ventura/TestExpectations

None of these should exist, we should instead have e.g.:

[ Monterey ] fast/dom/SelectorAPI/caseID.html [ Pass Failure ]

in mac-wk1 instead of mac-monterey-wk1.

Potentially:

LayoutTests/platform/gtk4/TestExpectations

should also not exist, but we don't have GTK version as a Test configuration option.

Note that even with these gone in WebKit, we can't redefine the DarwinPort._port_specific_expectations_files without breaking things internal to Apple where there are similar files (including in non-macOS ports) in ApplePort._apple_baseline_path.

See also bug 105599 where we started supporting TestExpectations files in all these directories.
Comment 1 Radar WebKit Bug Importer 2024-03-20 12:26:29 PDT 
<rdar://problem/125106495>