Bug 105599 - nrwt: use the same search path for baselines and TestExpectations on apple mac
Summary: nrwt: use the same search path for baselines and TestExpectations on apple mac
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Dirk Pranke
URL:
Keywords: NRWT
Depends on:
Blocks:
 
Reported: 2012-12-20 18:23 PST by Dirk Pranke
Modified: 2024-03-20 12:26 PDT (History)
7 users (show)

See Also:

Attachments
Patch (4.41 KB, patch)
2012-12-20 18:29 PST, Dirk Pranke 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dirk Pranke 2012-12-20 18:23:22 PST 
nrwt: use the same search path for baselines and TestExpectations on apple mac
Comment 1 Dirk Pranke 2012-12-20 18:29:21 PST 
Created attachment 180455 [details]
Patch
Comment 2 Dirk Pranke 2012-12-20 18:31:40 PST 
See bug 105583 for some context ...

it turns out that having the default logic for which expectation files to use match the default logic for the baseline search path is trickier than one might hope, since every port actually does this slightly differently.

This is probably bad, so we should clean it up, but I'm going to break this into little patches that affect ports individually where possible, starting w/ the apple mac port.
Comment 3 Ryosuke Niwa 2012-12-20 18:52:59 PST 
Do you know if this change affects any effective test expectations on each "leaf" port?
Comment 4 Dirk Pranke 2012-12-20 19:15:22 PST 
(In reply to comment #3)
> Do you know if this change affects any effective test expectations on each "leaf" port?

I do not know. You could determine this by running webkit-patch print-baselines --all --csv --platform mac\* before and after the patch and comparing the output.
Comment 5 Eric Seidel (no email) 2012-12-20 20:16:29 PST 
Comment on attachment 180455 [details]
Patch

I thought most of this logic was implemented in ApplePort these days. :)
Comment 6 Dirk Pranke 2013-01-14 15:28:44 PST 
rniwa, smfr, one of you want to weigh in on this?
Comment 7 Dirk Pranke 2013-01-14 15:46:49 PST 
thanks!
Comment 8 WebKit Review Bot 2013-01-14 15:52:10 PST 
Comment on attachment 180455 [details]
Patch

Clearing flags on attachment: 180455

Committed r139679: <http://trac.webkit.org/changeset/139679>
Comment 9 WebKit Review Bot 2013-01-14 15:52:14 PST 
All reviewed patches have been landed.  Closing bug.