RESOLVED FIXED270561
REGRESSION(275690@main): Broke run-benchmark outside of buildbot
https://bugs.webkit.org/show_bug.cgi?id=270561
Summary REGRESSION(275690@main): Broke run-benchmark outside of buildbot
WebKit Commit Bot
Reported 2024-03-05 22:15:18 PST
https://commits.webkit.org/275690@main introduced a regression: Broke run-benchmark outside of buildbot This is an automatic bug report generated by webkitbot. If this bug report was created because of a flaky test, please file a bug for the flaky test (if we don't already have one on file) and dup this bug against that bug so that we can track how often these flaky tests fail.
Attachments
REVERT of 275690@main (59.94 KB, patch)
2024-03-05 22:15 PST, WebKit Commit Bot
no flags
WebKit Commit Bot
Comment 1 2024-03-05 22:15:26 PST
Created attachment 470199 [details] REVERT of 275690@main Any committer can land this patch automatically by marking it commit-queue+. The commit-queue will build and test the patch before landing to ensure that the revert will be successful. This process takes approximately 15 minutes. If you would like to land the revert faster, you can use the following command: webkit-patch land-attachment ATTACHMENT_ID where ATTACHMENT_ID is the ID of this attachment.
EWS
Comment 2 2024-03-05 22:20:06 PST
Committed 275729@main (3451abb11ae9): <https://commits.webkit.org/275729@main> All reviewed patches have been landed. Closing bug and clearing flags on attachment 470199 [details].
Radar WebKit Bug Importer
Comment 3 2024-03-05 22:21:13 PST
Sam Sneddon [:gsnedders]
Comment 4 2025-01-23 10:12:44 PST
The breakage here, from Yusuke on Slack, was: ``` Traceback (most recent call last): … File "/Users/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py", line 167, in start run_benchmark_plan(args, args.plan) File "/Users/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/benchmark_runner/run_benchmark.py", line 109, in run_benchmark_plan runner.execute() File "/Users/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py", line 197, in execute self._run_benchmark(int(self._plan['count']), web_root) File "/Users/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/benchmark_runner/benchmark_runner.py", line 165, in _run_benchmark result = self._run_one_test(web_root, entry_point, iteration) File "/Users/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py", line 62, in _run_one_test raise error File "/Users/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/benchmark_runner/webserver_benchmark_runner.py", line 47, in _run_one_test self._http_server_driver.serve(web_root) File "/Users/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py", line 48, in serve self._find_http_server_port() File "/Users/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/simple_http_server_driver.py", line 65, in _find_http_server_port raise RuntimeError('The http server terminated unexpectedly with return code {} and with the following output:\n{}'.format(self._server_process.returncode, stdout_data + stderr_data)) RuntimeError: The http server terminated unexpectedly with return code 1 and with the following output: b'Traceback (most recent call last):\n File "/Users/yusukesuzuki/dev/OpenSource/Tools/Scripts/webkitpy/benchmark_runner/http_server_driver/http_server/twisted_http_server.py", line 16, in <module>\n from webkitpy.autoinstalled.twisted.internet import reactor\n File "/Users/yusukesuzuki/dev/OpenSource/Tools/Scripts/libraries/autoinstalled/python-3-arm64/twisted/internet/reactor.py", line 37, in <module>\n del sys.modules[\'twisted.internet.reactor\']\nKeyError: \'twisted.internet.reactor\'\n' ```
Note You need to log in before you can comment on or make changes to this bug.