Bug 270534 - REGRESSION(275690@main): [webkitpy][Win] NameError: name '_winreg' is not defined
Summary: REGRESSION(275690@main): [webkitpy][Win] NameError: name '_winreg' is not def...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on: 270561
Blocks:
  Show dependency tree / graph
 
Reported: 2024-03-05 12:29 PST by Fujii Hironori
Modified: 2024-03-11 08:24 PDT (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2024-03-05 12:29:05 PST 
After 275690@main bug#270475, WinCairo tester buildbots are broken.

> NameError: name '_winreg' is not defined

Buildbot: builder WinCairo-64-bit-Release-Tests build 3743
https://build.webkit.org/#/builders/728/builds/3743
Comment 1 Fujii Hironori 2024-03-05 12:37:54 PST 
Pull request: https://github.com/WebKit/WebKit/pull/25498
Comment 2 EWS 2024-03-05 12:40:38 PST 
Committed 275706@main (e6fda5d30717): <https://commits.webkit.org/275706@main>

Reviewed commits have been landed. Closing PR #25498 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-03-05 12:41:15 PST 
<rdar://problem/124089063>
Comment 4 WebKit Commit Bot 2024-03-05 22:15:23 PST 
Re-opened since this is blocked by bug 270561
Comment 5 Fujii Hironori 2024-03-07 18:22:38 PST 
35.3. _winreg — Windows registry access — Python 2.7.18 documentation
https://docs.python.org/2.7/library/_winreg.html

> Note The _winreg module has been renamed to winreg in Python 3. The 2to3 tool will automatically adapt imports when converting your sources to Python 3.
Comment 6 Fujii Hironori 2024-03-10 22:47:36 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/25700
Comment 7 EWS 2024-03-11 08:24:38 PDT 
Committed 275901@main (2e18c746deb2): <https://commits.webkit.org/275901@main>

Reviewed commits have been landed. Closing PR #25700 and removing active labels.