Bug 27008 - bugzilla-tool fails with bugzilla 3.0
Summary: bugzilla-tool fails with bugzilla 3.0
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2009-07-06 14:37 PDT by Eric Seidel (no email)
Modified: 2009-07-06 19:30 PDT (History)
0 users

See Also:


Attachments
patch (2.24 KB, patch)
2009-07-06 18:06 PDT, Eric Seidel (no email)
mjs: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Seidel (no email) 2009-07-06 14:37:39 PDT
I found one error, which I fixed:
-        self.browser['knob'] = ['resolve']
+        self.browser['bug_status'] = ['RESOLVED']

But now I'm hitting this nasty:

Traceback (most recent call last):
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 579, in <module>
    main()
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 576, in main
    return tool.main()
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 571, in main
    return command_object.execute(command_options, command_args, self)
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 354, in execute
    self.land_patches(bug_id, bugs_to_patches[bug_id], options, tool)
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 331, in land_patches
    tool.bugs.close_bug_as_fixed(bug_id, comment_text)
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/bugzilla.py", line 292, in close_bug_as_fixed
    self.browser.select_form(name="changeform")
  File "build/bdist.macosx-10.5-i386/egg/mechanize/_mechanize.py", line 505, in select_form
  File "build/bdist.macosx-10.5-i386/egg/mechanize/_html.py", line 546, in __getattr__
  File "build/bdist.macosx-10.5-i386/egg/mechanize/_html.py", line 559, in forms
  File "build/bdist.macosx-10.5-i386/egg/mechanize/_html.py", line 228, in forms
mechanize._html.ParseError%
Comment 1 Eric Seidel (no email) 2009-07-06 14:39:09 PDT
The parse error was hit while trying to land patches from:
https://bugs.webkit.org/show_bug.cgi?id=25061
Comment 2 Eric Seidel (no email) 2009-07-06 18:06:16 PDT
Created attachment 32339 [details]
patch
Comment 3 Maciej Stachowiak 2009-07-06 18:35:06 PDT
Comment on attachment 32339 [details]
patch

r=me
Comment 4 Eric Seidel (no email) 2009-07-06 19:19:01 PDT
Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/modules/bugzilla.py
	M	WebKitTools/Scripts/modules/scm.py
Committed r45580
	M	WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a
	M	WebKitLibraries/WebKitSystemInterface.h
	M	WebKitLibraries/ChangeLog
	M	WebKitLibraries/libWebKitSystemInterfaceLeopard.a
	M	WebKitLibraries/libWebKitSystemInterfaceTiger.a
r45563 = fd162b32e95aa06b3b031cce2246b7ae56518018 (trunk)
	M	WebCore/ChangeLog
	M	WebCore/bindings/v8/V8Binding.cpp
r45564 = ea9915cd1c5417e26ccbc8e09b4f2afb874ab791 (trunk)
	M	WebKit/mac/WebCoreSupport/WebSystemInterface.m
	M	WebKit/mac/ChangeLog
	M	WebCore/ChangeLog
	M	WebCore/WebCore.base.exp
	M	WebCore/page/mac/EventHandlerMac.mm
	M	WebCore/page/EventHandler.h
	M	WebCore/page/EventHandler.cpp
	M	WebCore/platform/mac/WebCoreSystemInterface.mm
	M	WebCore/platform/mac/WebCoreSystemInterface.h
r45565 = 8b5e4f39ff02cd99377a0399d61a6d2332f479d7 (trunk)
	M	JavaScriptCore/wtf/FastMalloc.cpp
	M	JavaScriptCore/ChangeLog
r45566 = 162c8cf48ef64628018343b5c2c1de20e65afc59 (trunk)
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderTextControl.cpp
	A	LayoutTests/platform/mac/editing/input/text-control-ime-input-expected.txt
	A	LayoutTests/platform/mac/editing/input/text-control-ime-input.html
	M	LayoutTests/ChangeLog
r45567 = 7deab11294610e0e1d008d61c69150772ed18397 (trunk)
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderFlexibleBox.cpp
	M	WebCore/rendering/RenderBlock.cpp
	M	WebCore/rendering/RenderBlock.h
	M	LayoutTests/ChangeLog
	A	LayoutTests/fast/flexbox/repaint-scrollbar-expected.txt
	A	LayoutTests/fast/flexbox/repaint-scrollbar.html
	A	LayoutTests/fast/flexbox/resources/repaint-scrollbar.js
r45568 = 52339b5a0ebb8366f59f26c4b326f14f225fb789 (trunk)
	M	WebCore/ChangeLog
	M	WebCore/platform/graphics/Color.h
	M	WebCore/WebCore.order
	M	WebCore/rendering/RenderThemeMac.mm
	M	WebCore/rendering/RenderThemeSafari.h
	M	WebCore/rendering/RenderThemeChromiumSkia.cpp
	M	WebCore/rendering/RenderThemeChromiumSkia.h
	M	WebCore/rendering/RenderThemeChromiumMac.mm
	M	WebCore/rendering/RenderThemeSafari.cpp
	M	WebCore/rendering/RenderThemeChromiumMac.h
	M	WebCore/rendering/RenderThemeMac.h
	M	WebCore/rendering/RenderTheme.cpp
	M	WebCore/rendering/RenderTheme.h
	M	WebCore/css/CSSStyleSelector.cpp
r45569 = 39f68b4dc18c91faaea1ed952b85c522950630a8 (trunk)
	M	WebCore/ChangeLog
	M	WebCore/rendering/InlineBox.cpp
	M	WebCore/rendering/RenderSVGInlineText.cpp
	M	WebCore/rendering/SVGInlineTextBox.h
	M	WebCore/rendering/SVGInlineFlowBox.h
	M	WebCore/rendering/RenderSVGText.cpp
	M	WebCore/rendering/RenderSVGInline.cpp
	M	WebCore/rendering/SVGRootInlineBox.h
	M	WebCore/rendering/InlineBox.h
r45570 = 0bc3a1356efe435f43de58095372a73b869cb918 (trunk)
	M	WebCore/ChangeLog
	M	WebCore/bridge/runtime_root.h
	M	WebCore/bridge/runtime_root.cpp
r45571 = a361203ec36c76ebe90e51fb1eea51fcb8ca00d7 (trunk)
	M	WebKitLibraries/libWebKitSystemInterfaceSnowLeopard.a
	M	WebKitLibraries/WebKitSystemInterface.h
	M	WebKitLibraries/ChangeLog
	M	WebKitLibraries/libWebKitSystemInterfaceLeopard.a
	M	WebKitLibraries/libWebKitSystemInterfaceTiger.a
	M	WebCore/ChangeLog
	M	WebCore/platform/mac/WebCoreSystemInterface.mm
	M	WebCore/platform/mac/WebCoreSystemInterface.h
	M	WebCore/rendering/RenderThemeMac.mm
	M	WebCore/rendering/MediaControlElements.cpp
	M	WebCore/rendering/MediaControlElements.h
	M	WebCore/rendering/RenderMedia.h
	M	WebCore/rendering/RenderMedia.cpp
r45572 = 3de935e2cb09e93bfbe864f99f3549f9a4311e27 (trunk)
	M	WebCore/ChangeLog
	M	WebCore/bindings/scripts/CodeGeneratorV8.pm
	D	WebCore/bindings/v8/V8Binding.cpp
	M	WebCore/bindings/v8/V8Proxy.cpp
	M	WebCore/bindings/v8/WorkerContextExecutionProxy.cpp
	M	WebCore/bindings/v8/V8LazyEventListener.cpp
	M	WebCore/bindings/v8/custom/V8DOMWindowCustom.cpp
	M	WebCore/bindings/v8/custom/V8CustomXPathNSResolver.cpp
	M	WebCore/bindings/v8/custom/V8HTMLCanvasElementCustom.cpp
	M	WebCore/bindings/v8/custom/V8WorkerContextCustom.cpp
	M	WebCore/bindings/v8/custom/V8CanvasRenderingContext2DCustom.cpp
	M	WebCore/bindings/v8/custom/V8XMLHttpRequestCustom.cpp
	M	WebCore/bindings/v8/custom/V8CSSStyleDeclarationCustom.cpp
	M	WebCore/bindings/v8/custom/V8HTMLOptionsCollectionCustom.cpp
	M	WebCore/bindings/v8/custom/V8HTMLSelectElementCustom.cpp
	M	WebCore/bindings/v8/custom/V8HTMLIFrameElementCustom.cpp
	M	WebCore/bindings/v8/custom/V8SQLTransactionCustom.cpp
	M	WebCore/bindings/v8/V8Binding.h
r45574 = 7a83c6d177143459ffd49e7ad6fe2106bc8e26ab (trunk)
	M	WebCore/ChangeLog
	M	WebCore/rendering/RenderThemeMac.mm
	M	LayoutTests/platform/mac-snowleopard/Skipped
	M	LayoutTests/ChangeLog
r45576 = f92b4bb3f1edfaa42e65b90f807fc0ab27627e66 (trunk)
	M	WebCore/editing/Editor.cpp
	M	WebCore/ChangeLog
r45577 = 4f84fae9cc27fa079c630ce518ee8f26a1b2dfbd (trunk)
	M	WebCore/ChangeLog
	M	WebCore/html/CanvasRenderingContext2D.cpp
r45578 = 33e9db66e2eca89b9619ef0f6e18535b696643c7 (trunk)
	M	WebKit/mac/Plugins/WebNetscapeContainerCheckPrivate.mm
	M	WebKit/mac/Plugins/WebNetscapeContainerCheckContextInfo.mm
	M	WebKit/mac/Plugins/WebNetscapeContainerCheckContextInfo.h
	M	WebKit/mac/ChangeLog
r45579 = 7adf5b839435bdfeff30989c260552c8273d3635 (trunk)
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/modules/bugzilla.py
	M	WebKitTools/Scripts/modules/scm.py
r45580 = 04d18f40d7fb3455553af530df851fcf6f66425b (trunk)
First, rewinding head to replay your work on top of it...
Nothing to do.
http://trac.webkit.org/changeset/45580
Comment 5 Eric Seidel (no email) 2009-07-06 19:30:30 PDT
Sorry!  I'll bump https://bugs.webkit.org/show_bug.cgi?id=26920 up in my queue.  That's what's causing all that extra junk in the bug comment!