Bug 269123 - [Wasm-GC] Fix assertions for global init import case
Summary: [Wasm-GC] Fix assertions for global init import case
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 247394
  Show dependency tree / graph
 
Reported: 2024-02-09 17:16 PST by Asumu Takikawa
Modified: 2024-02-14 10:53 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Asumu Takikawa 2024-02-09 17:16:43 PST 
In JSTests/wasm/gc/const-exprs.js if you change test cases in testConstExprGlobalOrdering() from "compile" to "instantiate" tests, you will get errors in a debug build due to some faulty assertions.

These assertions just need to be updated to reflect the new constraints with Wasm GC.
Comment 1 Asumu Takikawa 2024-02-09 18:29:14 PST 
Pull request: https://github.com/WebKit/WebKit/pull/24197
Comment 2 EWS 2024-02-14 10:52:21 PST 
Committed 274637@main (803d3064cdeb): <https://commits.webkit.org/274637@main>

Reviewed commits have been landed. Closing PR #24197 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2024-02-14 10:53:32 PST 
<rdar://problem/122958233>