Bug 26842 - Build fix when ENABLE_DATABASE is off
Summary: Build fix when ENABLE_DATABASE is off
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore JavaScript (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 25113 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-06-30 07:52 PDT by Kwang Yul Seo
Modified: 2009-07-01 19:04 PDT (History)
2 users (show)

See Also:

Attachments
ENABLE_DATABASE build fix (1.17 KB, patch)
2009-06-30 07:54 PDT, Kwang Yul Seo 		eric: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2009-06-30 07:52:07 PDT 
ScriptObjectQuarantine.cpp won't compile as Database.h is missing when ENABLE_DATABASE is off. 

Move #include "Database.h" into ENABLE(DATABASE) guard so toggling ENALBE_DATABASE off does not break builds.
Comment 1 Kwang Yul Seo 2009-06-30 07:54:31 PDT 
Created attachment 32065 [details]
ENABLE_DATABASE build fix

Build fix.
Comment 2 Eric Seidel (no email) 2009-06-30 14:34:42 PDT 
Comment on attachment 32065 [details]
ENABLE_DATABASE build fix

Looks fine.
Comment 3 Jan Alonzo 2009-06-30 18:35:03 PDT 
*** Bug 25113 has been marked as a duplicate of this bug. ***
Comment 4 Jan Alonzo 2009-06-30 18:55:19 PDT 
(In reply to comment #1)
> Created an attachment (id=32065) [review]
> ENABLE_DATABASE build fix
> 
> Build fix.
> 

I think this fix will break the other ports. If you look inside Database.h, the header is also used even if ENABLE_DATABASE is off (there's an else clause). 

Which port does this happen? If it's the Gtk port, you might want to move Database.h out of the ENABLE_DATABASE guard and put it in webcore_sources further up.
Comment 5 Eric Seidel (no email) 2009-07-01 19:04:26 PDT 
r45462