Bug 25113 - [GTK] Turning off sqlite don't work in ScriptObjectQuarantine
Summary: [GTK] Turning off sqlite don't work in ScriptObjectQuarantine
Status: RESOLVED DUPLICATE of bug 26842
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
: 26678 (view as bug list)
Depends on:
Blocks:
 
Reported: 2009-04-09 04:32 PDT by Mikkel Kruse Johnsen
Modified: 2009-06-30 18:35 PDT (History)
3 users (show)

See Also:

Attachments
Fix disabling off sqlite (1.85 KB, patch)
2009-04-09 04:33 PDT, Mikkel Kruse Johnsen 		no flags Details | Formatted Diff | Diff
Fix disabling off sqlite (1.1.5) (2.11 KB, patch)
2009-04-19 06:46 PDT, Mikkel Kruse Johnsen 		no flags Details | Formatted Diff | Diff
Fix disabling off sqlite (1.1.5), with ChangeLog (2.66 KB, patch)
2009-04-19 06:54 PDT, Mikkel Kruse Johnsen 		jmalonzo: review-
Details | Formatted Diff | Diff
Disabling of database (668 bytes, patch)
2009-05-16 05:50 PDT, Mikkel Kruse Johnsen 		no flags Details | Formatted Diff | Diff
Move Database.h inside check (1.31 KB, patch)
2009-06-21 04:40 PDT, Mikkel Kruse Johnsen 		no flags Details | Formatted Diff | Diff
Show Obsolete (4) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Mikkel Kruse Johnsen 2009-04-09 04:32:49 PDT 
Patch to fix it.
Comment 1 Mikkel Kruse Johnsen 2009-04-09 04:33:25 PDT 
Created attachment 29364 [details]
Fix disabling off sqlite
Comment 2 Jan Alonzo 2009-04-19 02:46:17 PDT 
(In reply to comment #1)
> Created an attachment (id=29364) [review]
> Fix disabling off sqlite
> 

This patch requires a ChangeLog. And also you might want to set the review flag to '?' once you've updated the patch.
Comment 3 Mikkel Kruse Johnsen 2009-04-19 06:46:37 PDT 
Created attachment 29605 [details]
Fix disabling off sqlite (1.1.5)
Comment 4 Mikkel Kruse Johnsen 2009-04-19 06:54:37 PDT 
Created attachment 29606 [details]
Fix disabling off sqlite (1.1.5), with ChangeLog
Comment 5 Jan Alonzo 2009-05-15 06:55:42 PDT 
Comment on attachment 29606 [details]
Fix disabling off sqlite (1.1.5), with ChangeLog

An almost similar patch was landed in r42709 - http://trac.webkit.org/changeset/42709.

r- because of this.
Comment 6 Jan Alonzo 2009-05-15 06:56:32 PDT 
Please confirm if this is still an issue.

Thanks.
Comment 7 Mikkel Kruse Johnsen 2009-05-16 05:49:41 PDT 
This is not fixed completly, one header is still not checked.

See patch.
Comment 8 Mikkel Kruse Johnsen 2009-05-16 05:50:22 PDT 
Created attachment 30413 [details]
Disabling of database
Comment 9 Jan Alonzo 2009-06-06 19:47:43 PDT 
(In reply to comment #8)
> Created an attachment (id=30413) [review]
> Disabling of database
> 

Hi Mikkel. Thanks. Your patch needs a ChangeLog. Please see http://webkit.org/coding/contributing.html for more info.
Comment 10 Mikkel Kruse Johnsen 2009-06-21 04:40:50 PDT 
Created attachment 31611 [details]
Move Database.h inside check

Here is the patch with ChangeLog included.
Comment 11 Jan Alonzo 2009-06-24 06:52:21 PDT 
*** Bug 26678 has been marked as a duplicate of this bug. ***
Comment 12 Jan Alonzo 2009-06-30 18:35:03 PDT 

*** This bug has been marked as a duplicate of 26842 ***