Bug 268258 - webrtc::SctpTransportInformation::state_ is not initialized in default constructor
Summary: webrtc::SctpTransportInformation::state_ is not initialized in default constr...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebRTC (show other bugs)
Version: Other
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: David Kilzer (:ddkilzer)
URL:
Keywords: InRadar
Depends on: 203897
Blocks:
  Show dependency tree / graph
 
Reported: 2024-01-28 10:21 PST by David Kilzer (:ddkilzer)
Modified: 2024-01-30 05:10 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description David Kilzer (:ddkilzer) 2024-01-28 10:21:39 PST 
webrtc::SctpTransportInformation::state_ is not initialized in default constructor.

Found by clang static analyzer.

Regressed in:

    Add missing file from https://trac.webkit.org/changeset/252472
    https://bugs.webkit.org/show_bug.cgi?id=203897
    https://commits.webkit.org/217513@main

Which was a follow-up fix for:

    Update libwebrtc to M78
    https://bugs.webkit.org/show_bug.cgi?id=203897
    https://commits.webkit.org/217512@main
Comment 1 Radar WebKit Bug Importer 2024-01-28 10:21:51 PST 
<rdar://problem/121811341>
Comment 2 David Kilzer (:ddkilzer) 2024-01-28 10:25:34 PST 
Pull request: https://github.com/WebKit/WebKit/pull/23388
Comment 3 David Kilzer (:ddkilzer) 2024-01-28 10:28:41 PST 
Filed upstream:

webrtc::SctpTransportInformation::state_ is not initialized in default constructor
<https://bugs.chromium.org/p/webrtc/issues/detail?id=15814>
Comment 4 EWS 2024-01-30 05:10:38 PST 
Committed 273738@main (5201724511e7): <https://commits.webkit.org/273738@main>

Reviewed commits have been landed. Closing PR #23388 and removing active labels.