Bug 203897 – Update libwebrtc to M78

• Status: RESOLVED
• Resolution: FIXED
• Component: WebRTC

[youenn fablet]

Update libwebrtc to M78

[youenn fablet]

Created attachment 382926 [details]
Patch

[youenn fablet]

Created attachment 382944 [details]
Patch

[youenn fablet]

Created attachment 383030 [details]
Patch

[youenn fablet]

Created attachment 383085 [details]
Patch

[youenn fablet]

Created attachment 383096 [details]
Patch

[youenn fablet]

Created attachment 383112 [details]
Patch

[youenn fablet]

Created attachment 383128 [details]
Patch

[Alex Christensen]

You might find https://bugs.webkit.org/show_bug.cgi?id=203753 interesting.  Maybe it could be put in with this, or just after?  Could whoever gets the GTK build working with this patch look at that one, too?

[youenn fablet]

(In reply to Alex Christensen from comment #8)
> You might find https://bugs.webkit.org/show_bug.cgi?id=203753 interesting. 
> Maybe it could be put in with this, or just after?  Could whoever gets the
> GTK build working with this patch look at that one, too?

Interesting, I was actually thinking we could switch to Sources.txt/SourcesCocoa.txt mechanism.
That would make it easier to update for all platforms.
That would also help MacOS CMake.

[youenn fablet]

Created attachment 383464 [details]
Patch with GTK/WPE fixes

[Thibault Saunier]

(In reply to Alex Christensen from comment #8)
> You might find https://bugs.webkit.org/show_bug.cgi?id=203753 interesting. 
> Maybe it could be put in with this, or just after?  Could whoever gets the
> GTK build working with this patch look at that one, too?

Sure, I will, I guess I will wait for that update patch to get in so you rebase and I have a look, is that OK for you?

[youenn fablet]

WPE bot does not seem to like it:  StreamsConfig::StreamsConfig(const StreamsConfig&) = default;
 ^~~~~~~~~~~~~
In file included from ../../Source/ThirdParty/libwebrtc/Source/webrtc/api/transport/network_types.cc:11:0:
../../Source/ThirdParty/libwebrtc/Source/webrtc/api/transport/network_types.h:39:66: error: union member ‘webrtc::StreamsConfig::<unnamed union>::min_total_allocated_bitrate’ with non-trivial ‘constexpr std::optional<webrtc::DataRate>::optional(const std::optional<webrtc::DataRate>&)’
     absl::optional<DataRate> min_total_allocated_bitrate = absl::nullopt;
                                                                  ^~~~~~~
../../Source/ThirdParty/libwebrtc/Source/webrtc/api/transport/network_types.h:41:45: error: union member ‘webrtc::StreamsConfig::<unnamed union>::min_pacing_rate’ with non-trivial ‘constexpr std::optional<webrtc::DataRate>::optional(const std::optional<webrtc::DataRate>&)’
     RTC_DEPRECATED absl::optional<DataRate> min_pacing_rate;

[youenn fablet]

Created attachment 383487 [details]
Patch with GTK/WPE fixes

[youenn fablet]

Created attachment 383509 [details]
Patch

[youenn fablet]

Created attachment 383572 [details]
Patch

[Eric Carlson]

Comment on attachment 383572 [details]
Patch

r=me once the bots are happy.

[youenn fablet]

Committed revision 252472.

[youenn fablet]

Committed missing files in revision 252473.

[Philippe Normand]

https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/26235/steps/compile-webkit/logs/stdio

[Philippe Normand]

Ah, that was solved, there's a link error now
https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Debug%20%28Build%29/builds/26241/steps/compile-webkit/logs/stdio