Bug 26745 – bugzilla-tool land-patches failed when landing multiple patches

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

Committed r45224
http://trac.webkit.org/changeset/45224
Traceback (most recent call last):
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 532, in <module>
    main()
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 529, in main
    return tool.main()
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 524, in main
    return command_object.execute(command_options, command_args, self)
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 313, in execute
    self.land_patches(bug_id, bugs_to_patches[bug_id], options, tool)
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/bugzilla-tool", line 285, in land_patches
    tool.bugs.obsolete_attachment(patch['id'], comment_text)
  File "/Users/eseidel/Projects/WebKit/WebKitTools/Scripts/modules/bugzilla.py", line 253, in obsolete_attachment
    self.browser['comment'] = comment_text
  File "/Library/Python/2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 2895, in __setitem__
  File "/Library/Python/2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 3222, in find_control
  File "/Library/Python/2.5/site-packages/ClientForm-0.2.10-py2.5.egg/ClientForm.py", line 3304, in _find_control
ClientForm.AmbiguityError: more than one control matching name 'comment'

I'm not sure what caused this yet.

[Eric Seidel (no email)]

I was trying to land all the patches on https://bugs.webkit.org/show_bug.cgi?id=26336

[Eric Seidel (no email)]

It also failed to mark the patch as obsolete, even though it said it was:

all 10758 test cases succeeded
Parsing ChangeLog: LayoutTests/ChangeLog
Logging in as [e-mail]...
Obsoleting attachment: 31458
Committing to http://svn.webkit.org/repository/webkit/trunk ...

I suspect that might have been the problem.  I might have broken attachment links somehow.  I also currently have the patch for:
https://bugs.webkit.org/show_bug.cgi?id=26740
in my tree, so it's possible this is a local-only break.

[Eric Seidel (no email)]

Created attachment 31899 [details]
patch

[Jan Alonzo]

Comment on attachment 31899 [details]
patch

> -            self.browser['comment'] = comment_text
> +            # Bugzilla has two textareas named 'comment', one is somehow hidden.  We want the first.
> +            self.browser.set_value(comment_text, name='comment', nr=0)

It's fine. r=me.

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/modules/bugzilla.py
Committed r45250
http://trac.webkit.org/changeset/45250