Bug 26740 – bugzilla-tool post-diff needs to obsolete old patches before posting

• Status: RESOLVED
• Resolution: FIXED
• Component: Tools / Tests

[Eric Seidel (no email)]

bugzilla-tool post-diff needs to obsolete old patches before posting

I've also added a --no-obsolete to disable this behavior.

I also finally updated the bug page parsing to use XML.  Thanks bdash! :)
So sad I wrote all that html parsing code in the first place. :(

[Eric Seidel (no email)]

Created attachment 31889 [details]
patch

[Eric Seidel (no email)]

Created attachment 31890 [details]
patch

[Jan Alonzo]

Comment on attachment 31890 [details]
patch

> +            log("Obsoleteting %s on bug %s" % (pluralize('old patch', len(patches)), bug_id))

Obsoleting :)

> -
> -            if str(review_status).find("review+") != -1:
> -                reviewer = review_status.contents[0].split(':')[0] # name:\n review+\n
> -                reviewer_full_name = self.full_name_from_bugzilla_name(reviewer)
> -                attachment['reviewer'] = reviewer_full_name
> +            attachment['is_obsolete'] = (element.has_key('isobsolete') and element['isobsolete'] == "1")
> +            attachment['is_patch'] = (element.has_key('ispatch') and element['ispatch'] == "1")

I think without '== "1"' should be fine as well.

r=me.

[Eric Seidel (no email)]

Committing to http://svn.webkit.org/repository/webkit/trunk ...
	M	WebKitTools/ChangeLog
	M	WebKitTools/Scripts/bugzilla-tool
	M	WebKitTools/Scripts/modules/bugzilla.py
Committed r45249
http://trac.webkit.org/changeset/45249