WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
26732
Combine LocalStorage and SessionStorage into StorageNamespace
https://bugs.webkit.org/show_bug.cgi?id=26732
Summary
Combine LocalStorage and SessionStorage into StorageNamespace
Jeremy Orlow
Reported
2009-06-25 14:32:25 PDT
For the final step of
https://bugs.webkit.org/show_bug.cgi?id=25376
, combine LocalStorage and SessionStorage into StorageNamespace. The synching code (for LocalStorage) has already been removed, so these classes are now very similar. All they do is essentially contain a logical grouping of origins that are attached to specific contexts (be it PageGroups for LocalStorage and Page for SessionStorage).
Attachments
patch v1
(60.99 KB, patch)
2009-06-25 16:57 PDT
,
Jeremy Orlow
fishd
: review+
Details
Formatted Diff
Diff
rebaselined version
(60.99 KB, patch)
2009-06-26 13:15 PDT
,
Jeremy Orlow
no flags
Details
Formatted Diff
Diff
resynced + added #include "DOMWindow.cpp" to storageArea.cpp
(60.99 KB, patch)
2009-06-26 15:32 PDT
,
Jeremy Orlow
dglazkov
: review+
Details
Formatted Diff
Diff
Show Obsolete
(2)
View All
Add attachment
proposed patch, testcase, etc.
Jeremy Orlow
Comment 1
2009-06-25 16:57:15 PDT
Created
attachment 31891
[details]
patch v1 For the final step of
https://bugs.webkit.org/show_bug.cgi?id=25376
, combine LocalStorage and SessionStorage into StorageNamespace. The synching code (for LocalStorage) has already been removed, so these classes are now very similar. All they do is essentially contain a logical grouping of origins that are attached to specific contexts (be it PageGroups for LocalStorage and Page for SessionStorage).
Jeremy Orlow
Comment 2
2009-06-26 13:15:33 PDT
Created
attachment 31946
[details]
rebaselined version No changes, just WebKitTools/Scripts/update-webkit'ed and re-created the patch. Recompiled and did ad-hoc testing to double check we're still good.
Jeremy Orlow
Comment 3
2009-06-26 15:32:05 PDT
Created
attachment 31956
[details]
resynced + added #include "DOMWindow.cpp" to storageArea.cpp resynced + added #include "DOMWindow.cpp" to storageArea.cpp. Recompiled/tested.
Jeremy Orlow
Comment 4
2009-06-26 16:14:16 PDT
landed by Dimitri in 45290
Eric Seidel (no email)
Comment 5
2009-06-30 03:13:02 PDT
Should this still be marked for review? The bug is closed.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug