Bug 26732 - Combine LocalStorage and SessionStorage into StorageNamespace
Summary: Combine LocalStorage and SessionStorage into StorageNamespace
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jeremy Orlow
URL:
Keywords:
Depends on:
Blocks: 25376
  Show dependency treegraph
 
Reported: 2009-06-25 14:32 PDT by Jeremy Orlow
Modified: 2009-06-30 09:35 PDT (History)
9 users (show)

See Also:


Attachments
patch v1 (60.99 KB, patch)
2009-06-25 16:57 PDT, Jeremy Orlow
fishd: review+
Details | Formatted Diff | Diff
rebaselined version (60.99 KB, patch)
2009-06-26 13:15 PDT, Jeremy Orlow
no flags Details | Formatted Diff | Diff
resynced + added #include "DOMWindow.cpp" to storageArea.cpp (60.99 KB, patch)
2009-06-26 15:32 PDT, Jeremy Orlow
dglazkov: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2009-06-25 14:32:25 PDT
For the final step of https://bugs.webkit.org/show_bug.cgi?id=25376, combine LocalStorage and SessionStorage into StorageNamespace.  The synching code (for LocalStorage) has already been removed, so these classes are now very similar.  All they do is essentially contain a logical grouping of origins that are attached to specific contexts (be it PageGroups for LocalStorage and Page for SessionStorage).
Comment 1 Jeremy Orlow 2009-06-25 16:57:15 PDT
Created attachment 31891 [details]
patch v1

For the final step of https://bugs.webkit.org/show_bug.cgi?id=25376, combine LocalStorage and SessionStorage into StorageNamespace. The synching code (for LocalStorage) has already been removed, so these classes are now very similar.  All they do is essentially contain a logical grouping of origins that are attached to specific contexts (be it PageGroups for LocalStorage and Page for SessionStorage).
Comment 2 Jeremy Orlow 2009-06-26 13:15:33 PDT
Created attachment 31946 [details]
rebaselined version

No changes, just WebKitTools/Scripts/update-webkit'ed and re-created the patch.  Recompiled and did ad-hoc testing to double check we're still good.
Comment 3 Jeremy Orlow 2009-06-26 15:32:05 PDT
Created attachment 31956 [details]
resynced + added #include "DOMWindow.cpp" to storageArea.cpp

resynced + added #include "DOMWindow.cpp" to storageArea.cpp.  Recompiled/tested.
Comment 4 Jeremy Orlow 2009-06-26 16:14:16 PDT
landed by Dimitri in 45290
Comment 5 Eric Seidel (no email) 2009-06-30 03:13:02 PDT
Should this still be marked for review?  The bug is closed.