Bug 26658 - Split the Synching portion of LocalStorageArea into its own class
Summary: Split the Synching portion of LocalStorageArea into its own class
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Jeremy Orlow
Depends on:
Blocks: 25376
  Show dependency treegraph
Reported: 2009-06-23 13:42 PDT by Jeremy Orlow
Modified: 2009-06-24 16:56 PDT (History)
9 users (show)

See Also:

patch v1 (60.83 KB, patch)
2009-06-23 13:43 PDT, Jeremy Orlow
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jeremy Orlow 2009-06-23 13:42:16 PDT
This is a sub-component of "Bug 25376: Refactor localStorage code for use in multi-process browsers" (https://bugs.webkit.org/show_bug.cgi?id=25376).
Comment 1 Jeremy Orlow 2009-06-23 13:43:36 PDT
Created attachment 31731 [details]
patch v1

Split the syncing portions of LocalStorageArea into StorageAreaSync.  This name will make more sense in the next patch (in this set) when LocalStorageArea and SessionStorageArea are merged to become simply StorageArea.  (Thus the synching portion of StorageArea is in StorageAreaSync.)

This looks like a big patch, but really all it's doing is splitting code and patching split-related things up.
Comment 2 Jeremy Orlow 2009-06-23 13:46:14 PDT
Oops, forgot to add everyone from the other bug to the CC list for this one.

Brady you're definitely the idea reviewer for this one as well.
Comment 3 Darin Fisher (:fishd, Google) 2009-06-24 16:51:54 PDT
Comment on attachment 31731 [details]
patch v1

> Index: WebCore/ChangeLog
> +2009-06-23  Jeremy Orlow  <jorlow@chromium.org>
> +
> +        Reviewed by NOBODY (OOPS!).
> +

nit: please include a bug link.

> +        * storage/StorageAreaSync.cpp: Copied from WebCore/storage/LocalStorageArea.cpp.
> +        (WebCore::StorageAreaSync::create):

nit: it is common practice to delete the list of methods for file copies since
they aren't that interesting to the reader of the ChangeLog.

Otherwise, R=me
Comment 4 Darin Fisher (:fishd, Google) 2009-06-24 16:56:30 PDT
Landed as http://trac.webkit.org/changeset/45124