265969 – Update or Remove tests leveraging historical 'getPropertyCSSValue'

Bug 265969 - Update or Remove tests leveraging historical 'getPropertyCSSValue'

Summary: Update or Remove tests leveraging historical 'getPropertyCSSValue'

Status:	RESOLVED DUPLICATE of bug 229912

Alias:	None

Product:	WebKit
Classification:	Unclassified
Component:	CSS (show other bugs)
Version:	WebKit Nightly Build
Hardware:	Unspecified Unspecified

Importance:	P2 Normal
Assignee:	Nobody

URL:
Keywords:	GoodFirstBug

Depends on:
Blocks:

Reported:	2023-12-06 15:03 PST by Ahmad Saleem
Modified:	2023-12-12 15:08 PST (History)
CC List:	3 users (show)

See Also:	266052

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.

Description Ahmad Saleem 2023-12-06 15:03:18 PST

Hi Team,

'getPropertyCSSValue' is historical and it cannot be removed without updating 'LayoutTests' relying on it.

So I am creating this bug as potential to merge few of Blink's commits as clean-up to update them and make it easier to remove 'getPropertyCSSValue' eventually.

Blink Commits: https://chromium.googlesource.com/chromium/blink/+/018db695b2fd41eccdf23a87f157611f0425465d , https://chromium.googlesource.com/chromium/blink/+/088bcb0bb1fc92f4144303a6650fcdccaacac5f9 , https://chromium.googlesource.com/chromium/blink/+/16138b933dbebe3e3570464c8e3cf01d530f2bcd , https://chromium.googlesource.com/chromium/blink/+/839bdc83ee530f8b972f4195587995a7bda22368 , https://chromium.googlesource.com/chromium/blink/+/47b9403fd8b928a324d35a71566548ce6592568a , https://chromium.googlesource.com/chromium/blink/+/98d37e56283bb920a7ec652ea9235f8f5fd87a7a , 
https://chromium.googlesource.com/chromium/blink/+/ab1811d8bf4e7fa18f9c6fa44e5a86bb7b2f7d17 , 
https://chromium.googlesource.com/chromium/blink/+/391870c98875dcff621ab992553ebf9f4f695012 , 
https://chromium.googlesource.com/chromium/blink/+/42fab77317a1ba7b9b91225c64460fff932d6312 , 
https://chromium.googlesource.com/chromium/blink/+/d264cf786c1b2a87f99e095e09ea00bb85ee4e69 , 
https://chromium.googlesource.com/chromium/blink/+/2c7a5a8bf7d3f37e0af669bb241886e3aceffbfb , 
https://chromium.googlesource.com/chromium/blink/+/b179bc4d8475adc7943745c6cabe6997202577dc , 

Thanks!

Comment 1 Ahmad Saleem 2023-12-06 16:10:43 PST

WIP PR - https://github.com/WebKit/WebKit/pull/21418

Will add other updates and merges tomorrow.

Comment 2 Ahmad Saleem 2023-12-07 19:13:07 PST

PR - https://github.com/WebKit/WebKit/pull/21418

Comment 3 Sam Sneddon [:gsnedders] 2023-12-12 15:06:21 PST


*** This bug has been marked as a duplicate of bug 229912 ***

Comment 4 Sam Sneddon [:gsnedders] 2023-12-12 15:07:07 PST

oh, sorry, I didn't notice you'd posted a PR here—I'd have done the dance in the opposite direction if I'd noticed!

I hope you don't mind changing the bug mentioned in the commit message!

Comment 5 Ahmad Saleem 2023-12-12 15:08:09 PST

(In reply to Sam Sneddon [:gsnedders] from comment #4)
> oh, sorry, I didn't notice you'd posted a PR here—I'd have done the dance in
> the opposite direction if I'd noticed!
> 
> I hope you don't mind changing the bug mentioned in the commit message!

Yes - no worries, I will fix. I am not feeling well, so might give it a go later this weekend. I will fix and clean-up more stuff.