Bug 265860 - [GStreamer][WebRTC] Missing support for parameter-less setLocalDescription()
Summary: [GStreamer][WebRTC] Missing support for parameter-less setLocalDescription()
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Philippe Normand
URL:
Keywords: InRadar
Depends on:
Blocks: GstWebRTC
  Show dependency tree / graph
 
Reported: 2023-12-05 04:44 PST by Philippe Normand
Modified: 2024-01-12 04:51 PST (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Philippe Normand 2023-12-05 04:44:47 PST 
imported/w3c/web-platform-tests/webrtc-stats/supported-stats.https.html times out because of that.
Comment 1 Philippe Normand 2024-01-11 06:54:02 PST 
The test times out actually because we don't support setLocalDescription() calls without argument. Re-titling accordingly.

The test will fail afterwards, because webrtcbin is not spec-compliant, see https://gitlab.freedesktop.org/gstreamer/gstreamer/-/issues/3218
Comment 2 Philippe Normand 2024-01-11 06:54:51 PST 
We can work-around this in WebKit until spec compliance issues are fixed.
Comment 3 Philippe Normand 2024-01-11 07:25:44 PST 
Pull request: https://github.com/WebKit/WebKit/pull/22659
Comment 4 EWS 2024-01-12 04:50:20 PST 
Committed 272968@main (274953f826fd): <https://commits.webkit.org/272968@main>

Reviewed commits have been landed. Closing PR #22659 and removing active labels.
Comment 5 Radar WebKit Bug Importer 2024-01-12 04:51:17 PST 
<rdar://problem/120899746>