Bug 265722 - [Wasm-GC] Make type reflection throw correctly in JS API
Summary: [Wasm-GC] Make type reflection throw correctly in JS API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 247394
  Show dependency treegraph
 
Reported: 2023-12-02 10:45 PST by Asumu Takikawa
Modified: 2024-02-16 17:30 PST (History)
1 user (show)

See Also:


Attachments

Note You need to log in before you can comment on or make changes to this bug.
Description Asumu Takikawa 2023-12-02 10:45:49 PST
Currently type reflection methods like `Global.type` should throw when they encounter types that cannot be represented, such as concrete reftypes (see https://github.com/WebAssembly/function-references/blob/main/proposals/function-references/Overview.md#type-reflection).

The behavior in JSC right now is that it hits an assertion, so we need to add an explicit exception throw case for all these cases.
Comment 1 Radar WebKit Bug Importer 2023-12-09 10:46:12 PST
<rdar://problem/119436228>
Comment 2 Asumu Takikawa 2024-02-15 20:35:29 PST
Pull request: https://github.com/WebKit/WebKit/pull/24576
Comment 3 EWS 2024-02-16 17:30:31 PST
Committed 274900@main (dafde6a4c8f5): <https://commits.webkit.org/274900@main>

Reviewed commits have been landed. Closing PR #24576 and removing active labels.