Bug 265628 - [Wasm-GC] Fix subtyping for nullref
Summary: [Wasm-GC] Fix subtyping for nullref
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebAssembly (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Nobody
URL:
Keywords: InRadar
Depends on:
Blocks: 247394
  Show dependency tree / graph
 
Reported: 2023-11-30 21:16 PST by Asumu Takikawa
Modified: 2023-12-01 11:41 PST (History)
2 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Asumu Takikawa 2023-11-30 21:16:15 PST 
Right now the subtype check for nullref is slightly wrong, in that it doesn't allow (ref null none) <: (ref null <idx>) where <idx> is some concrete array or struct type.

This was the intended behavior, but there's an error in the subtype check function (it returns too soon before the intended case).
Comment 1 Asumu Takikawa 2023-11-30 21:35:55 PST 
Pull request: https://github.com/WebKit/WebKit/pull/21143
Comment 2 EWS 2023-12-01 10:43:26 PST 
Committed 271395@main (eaa3fcf1d383): <https://commits.webkit.org/271395@main>

Reviewed commits have been landed. Closing PR #21143 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-12-01 10:44:14 PST 
<rdar://problem/119041089>