WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
264756
[web-animations] determining the interpolation interval should be shared in `KeyframeInterpolation`
https://bugs.webkit.org/show_bug.cgi?id=264756
Summary
[web-animations] determining the interpolation interval should be shared in `...
Antoine Quint
Reported
2023-11-13 11:15:20 PST
Currently the code to determine the interpolation interval, the "from" and "to" keyframes, is contained within `KeyframeEffect::setAnimatedPropertiesInStyle()`. As part of the work on threaded animation resolution (see
bug 250970
), we will need to share this logic with `AcceleratedEffect` as well. Now that we have a shared concept of a keyframe (see
bug 264747
), we can add a method to `KeyframeInterpolation` for that purpose with whatever virtual methods are required on a new share base class for `AcceleratedEffect` and `KeyframeEffect`.
Attachments
Add attachment
proposed patch, testcase, etc.
Antoine Quint
Comment 1
2023-11-13 11:21:46 PST
Pull request:
https://github.com/WebKit/WebKit/pull/20428
EWS
Comment 2
2023-11-13 22:25:01 PST
Committed
270692@main
(9bafc5fbd3e0): <
https://commits.webkit.org/270692@main
> Reviewed commits have been landed. Closing PR #20428 and removing active labels.
Radar WebKit Bug Importer
Comment 3
2023-11-13 22:26:14 PST
<
rdar://problem/118375013
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug