RESOLVED FIXED 264747
[web-animations] `KeyframeValue` and `AcceleratedEffectKeyframe` should derive from a shared base class 
https://bugs.webkit.org/show_bug.cgi?id=264747
Summary [web-animations] `KeyframeValue` and `AcceleratedEffectKeyframe` should deriv...
Antoine Quint
Reported 2023-11-13 08:42:23 PST
As part of the work on threaded animation resolution (see bug 250970), we will need to have the keyframe interpolation logic currently contained in `KeyframeEffect` also apply to `AcceleratedEffect`. This will require a fair amount of refactoring to move all the relevant code in a shared base class for both `KeyframeEffect` and `AcceleratedEffect`. The first step towards this goal is to have the keyframe class backing those animation effect classes, `KeyframeValue` and `AcceleratedEffectKeyframe`, use a shared base class.
Attachments
Add attachment proposed patch, testcase, etc.
Antoine Quint
Comment 1 2023-11-13 08:48:11 PST
Pull request: https://github.com/WebKit/WebKit/pull/20420
EWS
Comment 2 2023-11-13 11:03:05 PST
Committed 270648@main (893f4b23e527): <https://commits.webkit.org/270648@main> Reviewed commits have been landed. Closing PR #20420 and removing active labels.
Radar WebKit Bug Importer
Comment 3 2023-11-13 11:04:16 PST
<rdar://problem/118344599>
Note You need to log in before you can comment on or make changes to this bug.