Bug 263174 - [Win] Some layout tests are failing due to the CR LF line end style if they are checked out by Windows Git
Summary: [Win] Some layout tests are failing due to the CR LF line end style if they a...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: WebKit Nightly Build
Hardware: Unspecified Unspecified
: P2 Normal
Assignee: Fujii Hironori
URL:
Keywords: InRadar
Depends on:
Blocks: 240158
  Show dependency tree / graph
 
Reported: 2023-10-15 14:20 PDT by Fujii Hironori
Modified: 2023-10-15 18:50 PDT (History)
1 user (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Fujii Hironori 2023-10-15 14:20:24 PDT 
[Win] Some layout tests are failing due to the CR LF line end style if they are checked out by Windows Git

fast/dom/Range/surround-contents-font-face-crash.svg [ Failure ]
fast/dom/adopt-attribute-crash.svg [ Failure ]
http/tests/inspector/network/copy-as-fetch.html [ Failure ]
http/tests/inspector/network/resource-sizes-memory-cache.html [ Failure ]
http/tests/inspector/network/resource-sizes-network.html [ Failure ]
http/tests/xmlhttprequest/cache-override.html [ Failure ]
http/tests/xmlhttprequest/response-empty-arraybuffer.html [ Failure ]
js/dom/modules/module-integrity-bad-value-success-with-cache.html [ Failure ]
js/dom/modules/module-integrity-non-top-level.html [ Failure ]

That's because core.autocrlf=true is the defalut of Windows Git,
Add '-crlf' attributes for them.
See also 45745@main (bug#34645).
Comment 1 Fujii Hironori 2023-10-15 14:26:45 PDT 
Pull request: https://github.com/WebKit/WebKit/pull/19098
Comment 2 EWS 2023-10-15 18:49:01 PDT 
Committed 269350@main (d1882602c9b1): <https://commits.webkit.org/269350@main>

Reviewed commits have been landed. Closing PR #19098 and removing active labels.
Comment 3 Radar WebKit Bug Importer 2023-10-15 18:50:15 PDT 
<rdar://problem/116993720>