Bug 240158 – [WinCairo] Some integrity and WebIDLParser tests are failing if the EOL is CR LF (checked out by Windows Git)

• Status: REOPENED
• Component: New Bugs

[Fujii Hironori]

[WinCairo] Some integrity and WebIDLParser tests are failing if the EOL is CR LF (checked out by Windows Git)

https://build.webkit.org/#/builders/60/builds/6567

  imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/global-immutable-prototype.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/WebIDL/idlharness.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/reporting/idlharness.any.worker.html [ Failure ]
  js/dom/modules/module-integrity-bad-value-success-with-cache.html [ Failure ]
  js/dom/modules/module-integrity-non-top-level.html [ Failure ]

[Fujii Hironori]

Disabling core.autocrlf will fix it.

git config --system core.autocrlf false

[Fujii Hironori]

web-platform-tests is using .gitattributes to disable the EOL conversion.

https://github.com/web-platform-tests/wpt/commit/2aef503a5b83fd08f57b7277533293773176b445

[Fujii Hironori]

WinCairo bots fixed the issue by changing git configuration.
https://github.com/WebKitForWindows/docker-webkit-dev/commit/8d9c7fd63d7ffe6b072df38e0bbc084176bcb0a1

[Fujii Hironori]

The list of failing tests due to core.autocrlf=true:

  fast/dom/adopt-attribute-crash.svg [ Failure ]
  http/tests/inspector/network/resource-sizes-memory-cache.html [ Failure ]
  http/tests/inspector/network/resource-sizes-network.html [ Failure ]
  http/tests/xmlhttprequest/cache-override.html [ Failure ]
  http/tests/xmlhttprequest/response-empty-arraybuffer.html [ Failure ]
  http/wpt/push-api/pushSubscription.https.any.serviceworker.html [ Failure ]
  http/wpt/push-api/pushSubscriptionChangeEvent.any.serviceworker.html [ Failure ]
  http/wpt/service-workers/claim-worker-fetch-without-nesting.https.html [ Failure ]
  http/wpt/service-workers/cors-preflight-star.any-serviceworker.html [ Failure ]
  imported/w3c/web-platform-tests/WebIDL/ecmascript-binding/global-immutable-prototype.any.worker.html [ Failure ]
  imported/w3c/web-platform-tests/WebIDL/idlharness.any.worker.html [ Failure ]
  js/dom/modules/module-integrity-bad-value-success-with-cache.html [ Failure ]
  js/dom/modules/module-integrity-non-top-level.html [ Failure ]

[Fujii Hironori]

There are a lot of files checked in accidentally with CR-LF.
> git grep --cached -lI $'\r'

We should prevent Windows developers to check in CR-LF.
> git config --global core.autocrlf input

[Fujii Hironori]

LayoutTests/.gitattributes has `-crlf`.
https://github.com/WebKit/WebKit/blob/204cc1e1e3a384a40bed51c2bd73cbe4df86b1fe/LayoutTests/.gitattributes

`-crlf` is old style of `-text`.
https://git-scm.com/docs/gitattributes

It was added by 45745@main (bug#34645).

[Fujii Hironori]

Because core.autocrlf=true is the defalut of Windows Git, I think we should add something to LayoutTests/.gitattributes.

> fast/dom/adopt-attribute-crash.svg eol=lf

[Fujii Hironori]

remaining failures:

  http/wpt/push-api/pushSubscription.https.any.serviceworker.html [ Failure ]
  http/wpt/push-api/pushSubscriptionChangeEvent.any.serviceworker.html [ Failure ]
  http/wpt/service-workers/cors-preflight-star.any-serviceworker.html [ Failure ]

[Fujii Hironori]

One more:

  fast/dom/Range/detach-range-during-deletecontents.html [ Timeout ]